Closed
Bug 1393715
Opened 7 years ago
Closed 7 years ago
Remove JSFUN_STUB_GSOPS and JS_FS
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
16.95 KB,
patch
|
arai
:
review+
|
Details | Diff | Splinter Review |
With bug 1389510 fixed, JSFUN_STUB_GSOPS is a no-op so we can remove it. After that, the JS_FS and JS_FN macros do exactly the same thing, so we can remove one of them. I removed JS_FS because JS_FN has more uses and similar macros use "FN" as well (JS_INLINABLE_FN, JS_FN_HELP, etc). Originally FS stood for FunctionSpec and FN for FastNative. Nowadays FN just means "Function" :)
Attachment #8901101 -
Flags: review?(arai.unmht)
|
Assignee | |
Comment 1•7 years ago
|
||
There are also some uses of JS_FS in jsapi-tests/testProfileStrings.cpp I'll rename these to JS_FN as well.
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8901101 [details] [diff] [review] Patch Review of attachment 8901101 [details] [diff] [review]: ----------------------------------------------------------------- nice :) r+ with the fix for testProfileStrings.cpp
Attachment #8901101 -
Flags: review?(arai.unmht) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4c5ee171517b Remove JSFUN_STUB_GSOPS and JS_FS. r=arai
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4c5ee171517b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•