Closed
Bug 1393719
Opened 7 years ago
Closed 6 years ago
Vendor taskcluster-client.py in tree
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: jhford, Assigned: jhford)
References
Details
Attachments
(1 file)
258.27 KB,
patch
|
gps
:
review-
|
Details | Diff | Splinter Review |
We should use taskcluster-client.py to interact with taskcluster. In order to do that efficiently, we should vendor it in tree. This bug tracks vendoring taskcluster-client.py and dependent bugs will be filed for the dependencies of taskcluster-client.py
Assignee | ||
Comment 1•7 years ago
|
||
The tc-client.py dependencies are: 'requests>=2.4.3,<3' -- in tree version: 2.9.1, no change needed 'mohawk>=0.3.4,<0.4' -- not in tree, needs vendoring 'slugid>=1.0.7,<2' -- in tree version: 1.0.6, needs update 'six>=1.10.0,<2' -- in tree version: 1.10.0, no change needed
Assignee | ||
Comment 2•7 years ago
|
||
This patch adds the taskcluster-client.py library to the in-tree vendored python libraries. I did this by importing the python2 wheel from pypi, but removed the async module since my understanding is that mozilla's in-tree python is purely 2.7.
The only difference between the py2 and py3 wheel that I'm aware of is that the py2 wheel does not have the correct dependencies for doing async operations. The async modules will cause syntax errors in 2.7, so the only reason to include them would be to allow the non-mach managed python interpreter use the in-tree vendored copy of the library.
Aside from removal of the async directory, there are no changes between the imported copy of the library and the contents of the wheel file.
$ ./mach python
Python 2.7.13 (default, Jul 18 2017, 09:17:00)
[GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import taskcluster as T
>>> P = T.AwsProvisioner()
>>> P.workerType('gecko-decision')
{u'workerType': u'gecko-decision', u'scalingRatio': 0, u'availabilityZones': [], u'canUseSpot': True, u'launchSpec':<SNIP>
Comment 3•7 years ago
|
||
Comment on attachment 8901772 [details] [diff] [review] add taskcluster-client.py Review of attachment 8901772 [details] [diff] [review]: ----------------------------------------------------------------- Please import a source distribution, not the contents of a wheel. Again, we need a setup.py file. Also, we are in the process of supporting more Python 3 in the repo. So please add Python 3 only code if it is there so people can use it if they want.
Attachment #8901772 -
Flags: review?(gps) → review-
Updated•6 years ago
|
Product: Core → Firefox Build System
Assignee | ||
Updated•6 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•