1393729 - Unable to register device after changing the Region and Language to DE

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Simon Basca [:SimonB]]

Build: master bbaa76973a
Device: iPad Air 2
iOS: 10.3.3

Steps to reproduce:
1. Go to device setting and change the Region and Language to DE
2. Launch Fennec
3. Try to register the device to Leanplum

Actual results:
- The device does not show up in the Development Devices list in Leanplum. This works fine for all the other SupportedLocales. 

Expected results:
- We should be able to register devices from all the supported locals.

Comment 1

[:sdaswani]

That's really odd. First step is to confirm what the locale string is with those settings.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Simon, can you also verify that you are able to login to FxA for locales that are part, and not part, of the Leanplum list? And verify that you can receive FxA (Tab) notifications?

Comment 3

[Simon Basca [:SimonB]]

(In reply to Stefan Arentz [:st3fan] from comment #2)
> Simon, can you also verify that you are able to login to FxA for locales
> that are part, and not part, of the Leanplum list? And verify that you can
> receive FxA (Tab) notifications?

I tried to log in to FxA or locales that are part (en_US, en_GB, en_AU) and that are not part (en_GR, en_RO) and I am receiving FxA (Tab) notifications.

I also tried to register the device to Leanplum with all the supported locales form the code:

private enum SupportedLocales: String {
    case US = "en_US"
    case DE = "de"
    case UK = "en_GB"
    case CA_EN = "en_CA"
    case AU = "en_AU"
    case TW = "zh_TW"
    case HK = "en_HK"
    case SG_EN = "en_SG"
}

They all work except the DE= "de" case. I switch the language and region to "Deutsch" and region to "Deutschland" and the device does not show up in the Leanplum Development Devices to register the device. Also the device doesn't show up in the Leanplum Development Devices for other unsupported cases (e.g Romania, language english) which is expected.

Comment 4

[Justin D'Arcangelo [:justindarc]]

Does this need addressed in 8.3 still?

Comment 5

[:sdaswani]

(In reply to Justin D'Arcangelo [:justindarc] from comment #4)
> Does this need addressed in 8.3 still?

Yes.

Comment 6

[Farhan Patel [:farhan]]

Reviewed by Susheel on GH
master https://github.com/mozilla-mobile/firefox-ios/commit/f593ce70861cae48e522ca611242539ba83952cc

Comment 7

[Farhan Patel [:farhan]]

uplifted to v8.x and v9.x

Comment 8

[Simon Basca [:SimonB]]

Verifying as fix on master b259426ff1a5a5.

Comment 9

[Simon Basca [:SimonB]]

Verifying as fix on 8.3(5755).

Comment 10

[Simon Basca [:SimonB]]

Correcting comment 9. This was verified on 8.3(5817).