1393748 - Consolidate places sidebar styling

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Dão Gottwald [:dao]]

osx/places/places.css applies some useless styles #sidebar-search-container and #tabs-panel from the synced tabs sidebar which doesn't even use places.css. It also seems to overuse !important.

windows/places/places.css makes an obsolete distinction between default and non-default themes when removing the tree's background and applies an obsolete custom background on Windows 7. qe-verify+ for this.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1393748 - Consolidate places sidebar styling.

osx/places/places.css applies some useless styles #sidebar-search-container and #tabs-panel from the synced tabs sidebar which doesn't even use places.css. It also seems to overuse !important.

windows/places/places.css makes an obsolete distinction between default and non-default themes when removing the tree's background and applies an obsolete custom background on Windows 7.

Review commit: https://reviewboard.mozilla.org/r/172630/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172630/

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8901155 [details]
Bug 1393748 - Consolidate places sidebar styling.

https://reviewboard.mozilla.org/r/172630/#review178300

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cc5adcf4e0a
Consolidate places sidebar styling. r=nhnt11

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3cc5adcf4e0a

Comment 5

[Deac Alin]

Hi Dão Gottwald,
Can you please explain what needs to be tested here(QA)? And/or provide steps. Thank you

Comment 6

[Dão Gottwald [:dao]]

(In reply to Deac Alin from comment #5)
> Hi Dão Gottwald,
> Can you please explain what needs to be tested here(QA)? And/or provide
> steps. Thank you

from comment 0:
> windows/places/places.css makes an obsolete distinction between default and
> non-default themes when removing the tree's background and applies an
> obsolete custom background on Windows 7. qe-verify+ for this.

So basically, we need to verify that the sidebar's background look as expected on Windows 7.

Comment 7

[Deac Alin]

Thank you for the clarifications. Tested on Windows 7 x 64 with latest FF Nightly 57.0a1(2017-09-18) Build ID:20170918220054 
As per spec http://design.firefox.com/people/shorlander/photon/Mockups/windows-7.html  when changing the Theme (Examples: Dark, Lotus) the background color for the sidebar changes aswell, which is not the case when using the latest Nightly. The background color for the sidebar remains the same (white). Is this intended? Thank you

Comment 8

[Dão Gottwald [:dao]]

(In reply to Deac Alin from comment #7)
> Thank you for the clarifications. Tested on Windows 7 x 64 with latest FF
> Nightly 57.0a1(2017-09-18) Build ID:20170918220054 
> As per spec
> http://design.firefox.com/people/shorlander/photon/Mockups/windows-7.html 
> when changing the Theme (Examples: Dark, Lotus) the background color for the
> sidebar changes aswell, which is not the case when using the latest Nightly.
> The background color for the sidebar remains the same (white). Is this
> intended? Thank you

That's bug 1385518.