1393751 - [Shield][Opt-Out] Cannot select Add-on from dropdown menu

Status: RESOLVED FIXED

(Shield :: General, defect)

Description

[Deac Alin]

Attachment: Add-on select.mov

Preconditions
You need access to Admin interface (for this Test Suite, https://normandy-admin.stage.mozaws.net/control
1. Obtain a copy of Firefox with the SHIELD recipe client system add-on installed. You can check about:support to ensure that you have it.
2. Set the extensions.shield-recipe-client.dev_mode preference to true to run recipes immediately on startup.
3. Set the extensions.shield-recipe-client.logging.level preference to 0 to enable more logging.
4. Set the security.content.signature.root_hash preference to DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90
5. Set the preference value for extensions.shield-recipe-client.api_url set to https://normandy.stage.mozaws.net/api/v1

[Environment:]
57.0a1 20170824100243
 MAC OsX 10.12 & Ubuntu 16.04

[Steps:]
1.Open Admin Interface.
2.Open the extension page. (https://normandy-admin.stage.mozaws.net/control/extension/)
3.Click Add New, Upload and save a new Extension.
4.Open control interface.
5.In the Control Interface, Click on Add New.
6.In the Name field, set a recipe name.
7.In the Filter Expression set a filter expression (e.g. normandy.isDefaultBrowser).
8.From the action DropDown, select type "Opt-Out Study"
9.In the Study Name input the Name of the study
10.From the Add-on dropdown select the extension uploaded at step 3.

[Actual Result:]
10. When trying to select the extension from Step 3, from the Add-on drop down menu, the option is not selectable.

For more details check the attached screen record 

[Expected Result:]
10. The Extension created at Step 3 can be selected from the Add-on drop down menu

Comment 1

[Osmose [:osmose, :mkelly]]

This only affects some of the extensions in the list, specifically ones that share the same filename. For some reason, the last four items in the select box in the video (fff, ffff, etc.) all share the same filename: https://net-mozaws-stage-us-east-1-normandy.s3.amazonaws.com/extensions/bootstrap-addon-example-signed.xpi. This shouldn't be possible.

The other extensions can still be selected, so I'm downgrading this from critical, but we shouldn't allow multiple extensions to refer to the same file.

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/normandy

https://github.com/mozilla/normandy/commit/a44ac1f853eca2bc88316cbfa3c0aa3ecdd3187c
Fix bug 1393751: Do not reuse XPI filenames in prod configurations.