Closed Bug 1393771 Opened 3 years ago Closed 3 years ago

Drop some bug numbers from test file names in browser/components/places/tests/browser/

Categories

(Firefox :: Bookmarks & History, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(2 files)

I was looking for some existing tests and found it hard due to the old use of bug numbers in names. As I was waiting for a build at the time, I decided to change the names.
Comment on attachment 8901172 [details]
Bug 1393771 - Rename some tests in browser/components/places/tests/browser/ to avoid bug numbers in filenames.

https://reviewboard.mozilla.org/r/172646/#review178274

Please check if any of these has bugs (like intermittent failures) filed for it and update their title with the new name.
Attachment #8901172 - Flags: review?(mak77) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/894a3b7efcdd
Rename some tests in browser/components/places/tests/browser/ to avoid bug numbers in filenames. r=mak
Wouldn't that be sweet, if our tests were actually independent and could survive the reordering that comes from renaming?

Backed out in https://hg.mozilla.org/integration/autoland/rev/20fc934d4ad7 for https://treeherder.mozilla.org/logviewer.html#?job_id=126145422&repo=autoland
Depends on: 1394801
Well, reordering found a bug (bug 1394801) :-)

The extra patch here fixes the remaining issues once bug 1394801 has landed.
Comment on attachment 8902408 [details]
Bug 1393771 - Fix issues in tests that cause failures when they are re-ordered.

https://reviewboard.mozilla.org/r/173988/#review179496
Attachment #8902408 - Flags: review?(mak77) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s a10dd9c6eccb -d 8cb237283ed0: rebasing 416838:a10dd9c6eccb "Bug 1393771 - Rename some tests in browser/components/places/tests/browser/ to avoid bug numbers in filenames. r=mak"
merging browser/components/places/tests/browser/browser.ini
warning: conflicts while merging browser/components/places/tests/browser/browser.ini! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8516c3269916
Rename some tests in browser/components/places/tests/browser/ to avoid bug numbers in filenames. r=mak
https://hg.mozilla.org/integration/autoland/rev/8e979942519c
Fix issues in tests that cause failures when they are re-ordered. r=mak
https://hg.mozilla.org/mozilla-central/rev/8516c3269916
https://hg.mozilla.org/mozilla-central/rev/8e979942519c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.