1393803 - Building installer on Linux fails: 7z not found

Status: RESOLVED FIXED

(Firefox :: Installer, defect, P1)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Okay this one I think really is the installer.

> [task 2017-08-25T13:54:23.782909Z] 13:54:23     INFO -  cd ../../../installer-stage &&  7z a -r -t7z /home/worker/workspace/build/src/obj-firefox/browser/installer/windows/instgen/app.7z -mx -m0=BCJ2 -m1=LZMA:d25 -m2=LZMA:d19 -m3=LZMA:d19 -mb0:1 -mb0s1:2 -mb0s2:3
> [task 2017-08-25T13:54:23.783008Z] 13:54:23     INFO -  /bin/sh: 7z: command not found

This will require two fixes: one to add p7zip to the image, and another to make the 7z command a variable.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1393803 Parameterize 7z and look for it in moz.configure

Review commit: https://reviewboard.mozilla.org/r/172684/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172684/

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8901208 [details]
Bug 1393803 Parameterize 7z and look for it in moz.configure

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172684/diff/1-2/

Comment 3

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1393803 Add p7zip to te docker image

Review commit: https://reviewboard.mozilla.org/r/172792/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172792/

Comment 4

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8901208 [details]
Bug 1393803 Parameterize 7z and look for it in moz.configure

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172684/diff/2-3/

Comment 5

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Okay, I'm not going to try and land this before Bug 1330608 just for commit reasons, but if the image gets upx (which is provded via a toolchain job in 1330608) then the attached patches will fix this one.

Comment 6

[Molly Howell (she/her) (no longer active)]

Just assigning a priority for bookkeeping purposes; since this is currently in progress it gets to be P1.

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8901208 [details]
Bug 1393803 Parameterize 7z and look for it in moz.configure

https://reviewboard.mozilla.org/r/172684/#review179868

::: moz.configure:547
(Diff revision 3)
> +        '7z',
> +        '7za',
> +    ]
> +
> +    return tuple(candidates)
> +check_prog('7Z', sevenz_program, allow_missing=True)

a shorter way to do this is check_prog('7Z', ('7z', '7za'), allow_missing=True, when=target_is_windows)

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 8901329 [details]
Bug 1393803 Add p7zip to te docker image

https://reviewboard.mozilla.org/r/172792/#review179888

I think you should just fold this in the other bug. (Otherwise you can't even land this before the other bug)

Comment 9

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8901208 [details]
Bug 1393803 Parameterize 7z and look for it in moz.configure

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172684/diff/3-4/

Comment 10

[Mike Hommey [:glandium]]

Comment on attachment 8901208 [details]
Bug 1393803 Parameterize 7z and look for it in moz.configure

https://reviewboard.mozilla.org/r/172684/#review183624

Comment 11

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a68541e60847b015c86e714dce361f5bebe89cc8

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1105de1e6820
Parameterize 7z and look for it in moz.configure r=glandium

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1105de1e6820