Closed Bug 1393803 Opened 3 years ago Closed 3 years ago

Building installer on Linux fails: 7z not found

Categories

(Toolkit :: NSIS Installer, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tor])

Attachments

(1 file, 1 obsolete file)

Okay this one I think really is the installer.

> [task 2017-08-25T13:54:23.782909Z] 13:54:23     INFO -  cd ../../../installer-stage &&  7z a -r -t7z /home/worker/workspace/build/src/obj-firefox/browser/installer/windows/instgen/app.7z -mx -m0=BCJ2 -m1=LZMA:d25 -m2=LZMA:d19 -m3=LZMA:d19 -mb0:1 -mb0s1:2 -mb0s2:3
> [task 2017-08-25T13:54:23.783008Z] 13:54:23     INFO -  /bin/sh: 7z: command not found

This will require two fixes: one to add p7zip to the image, and another to make the 7z command a variable.
Okay, I'm not going to try and land this before Bug 1330608 just for commit reasons, but if the image gets upx (which is provded via a toolchain job in 1330608) then the attached patches will fix this one.
Just assigning a priority for bookkeeping purposes; since this is currently in progress it gets to be P1.
Priority: -- → P1
Comment on attachment 8901208 [details]
Bug 1393803 Parameterize 7z and look for it in moz.configure

https://reviewboard.mozilla.org/r/172684/#review179868

::: moz.configure:547
(Diff revision 3)
> +        '7z',
> +        '7za',
> +    ]
> +
> +    return tuple(candidates)
> +check_prog('7Z', sevenz_program, allow_missing=True)

a shorter way to do this is check_prog('7Z', ('7z', '7za'), allow_missing=True, when=target_is_windows)
Attachment #8901208 - Flags: review?(mh+mozilla)
Comment on attachment 8901329 [details]
Bug 1393803 Add p7zip to te docker image

https://reviewboard.mozilla.org/r/172792/#review179888

I think you should just fold this in the other bug. (Otherwise you can't even land this before the other bug)
Attachment #8901329 - Flags: review?(mh+mozilla)
Comment on attachment 8901208 [details]
Bug 1393803 Parameterize 7z and look for it in moz.configure

https://reviewboard.mozilla.org/r/172684/#review183624
Attachment #8901208 - Flags: review?(mh+mozilla) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1105de1e6820
Parameterize 7z and look for it in moz.configure r=glandium
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1105de1e6820
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.