Closed
Bug 1393980
Opened 7 years ago
Closed 7 years ago
Create a bootstrap add-on to switch a user to SBv4
Categories
(Toolkit :: Safe Browsing, enhancement, P1)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
People
(Reporter: francois, Assigned: francois)
References
()
Details
(Whiteboard: #sbv4-m9)
Attachments
(1 file, 2 obsolete files)
1.92 KB,
application/x-xpinstall
|
Details |
We can based our addon on https://hg.mozilla.org/releases/mozilla-release/file/10a244c0f835/browser/extensions/clicktoplay-rollout/bootstrap.js#l84 (added in bug 1365714). Note: the above code is using Preferences.jsm, but we should use Services.prefs directly as Preferences.jsm is deprecated. Ideally, we should be using default prefs (as opposed to user prefs) so that no explicit cleanup is needed. However we need to test whether or not a reboot is necessary after switching from V2 to V4. If a reboot is necessary, we can't use default prefs.
Assignee | ||
Comment 1•7 years ago
|
||
:felipe has offered to review the add-on once it's ready. Once the add-on is signed, we should NEEDINFO :rehan to move this forward.
Assignee | ||
Updated•7 years ago
|
Summary: Create a bootstrap system add-on to switch a user to SBv4 → Create a bootstrap add-on to switch a user to SBv4
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → kardekani
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•7 years ago
|
||
Here are the prefs for V4: pref("urlclassifier.malwareTable", "goog-malware-proto,goog-unwanted-proto,test-malware-simple,test-unwanted-simple"); pref("urlclassifier.phishTable", "goog-phish-proto,test-phish-simple"); pref("urlclassifier.downloadAllowTable", "goog-downloadwhite-proto"); pref("urlclassifier.downloadBlockTable", "goog-badbinurl-proto");
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Assignee: kardekani → francois
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 3•7 years ago
|
||
Here's the add-on I've tested in beta with the patch from bug 1393954.
Assignee | ||
Comment 4•7 years ago
|
||
Michelle, we're going to use an add-on to roll out an internal Firefox feature in release 56. The only thing that will be visible to users will be the following screen if users actually go into the add-on preferences. Here's the copy in text form: Safe Browsing Version 4 (temporary add-on) By Firefox Team This temporary add-on enables the new version of the Safe Browsing API which automatically protects against dangerous and deceptive sites. It will be automatically removed once the gradual roll-out of this feature is complete. Would you like me to make any changes?
Flags: needinfo?(mheubusch)
Assignee | ||
Comment 5•7 years ago
|
||
Here is the test plan I followed in comment 3: 1. build Firefox 56 beta with the patch from bug 1393954 2. start that Firefox build in a fresh profile 3. open about:url-classifier 4. verify that you can successfully trigger an update for google, but not for google4 5. go into about:debugging and tick "enable add-on debugging" 6. load the attached add-on 7. go back into about:url-classifier 8. verify that you can successfully trigger an update for google4, but not for google (opposite of Step 4) 9. go into about:addons and remove the Safe Browsing Version 4 add-on 10. go back into about:url-classifier 11. verify that you can successfully trigger an update for google, but not for google4 (same as Step 4)
Updated•7 years ago
|
Flags: needinfo?(mkelly)
Flags: needinfo?(mcooper)
Updated•7 years ago
|
Flags: needinfo?(mkelly)
Flags: needinfo?(mcooper)
Assignee | ||
Comment 6•7 years ago
|
||
(In reply to François Marier [:francois] from comment #4) > Safe Browsing Version 4 (temporary add-on) > By Firefox Team > > This temporary add-on enables the new version of the Safe Browsing API > which automatically protects against dangerous and deceptive sites. > It will be automatically removed once the gradual roll-out of this > feature is complete. Michelle's comments on the add-on description: - add a comma between "API" and "which" - remove the word "automatically" between "which" and "protects" - remove the "gradual" between "the" and "roll-out"
Flags: needinfo?(mheubusch)
Assignee | ||
Comment 7•7 years ago
|
||
New version of the add-on: - copy changes requested by Michelle - marked as multiprocessCompatible so that it runs on 57 - auto-uninstalls itself if it runs on Firefox 57+
Attachment #8906194 -
Attachment is obsolete: true
Attachment #8906196 -
Attachment is obsolete: true
Assignee | ||
Comment 8•7 years ago
|
||
Here are builds of beta with the patch from bug 1393954 applied: Linux32: https://queue.taskcluster.net/v1/task/aFDb7FnYSD29j-fO6dwIEQ/runs/0/artifacts/public/build/target.tar.bz2 Linux64: https://queue.taskcluster.net/v1/task/Qvk1QB8USOm9uCaicT2IEQ/runs/0/artifacts/public/build/target.tar.bz2 Win32: https://queue.taskcluster.net/v1/task/TJS1ql5oSyS9FE9jok1Y7Q/runs/0/artifacts/public/build/target.zip Win64: https://queue.taskcluster.net/v1/task/D7f9Q9YSSTqppD3OzcCwtg/runs/0/artifacts/public/build/target.zip Mac: https://queue.taskcluster.net/v1/task/WS8184uAR1mrW519ydx5_A/runs/0/artifacts/public/build/target.dmg
Assignee | ||
Comment 9•7 years ago
|
||
Sign-off from Cristian Comorasu of Soft Vision: "I tested using STR from https://bugzilla.mozilla.org/show_bug.cgi?id=1393980#c5 and the XPI from the same bug, with the builds from https://bugzilla.mozilla.org/show_bug.cgi?id=1393980#c8. I am happy to say that the browser behaved accordingly and no issues were found, below you have a list of platforms I tested on. Windows 10 x64 Windows 7 x32 Ubuntu 16.04 LTS x64 Ubuntu 16.04 LTS x32 mac OS X 10.12.6" Michael, I believe that's all you needed before signing the XPI and uploading it to Normandy?
Flags: needinfo?(mkelly)
Comment 10•7 years ago
|
||
The add-on from comment 7 has been signed and uploaded to Normandy. It should be ready for use in a recipe.
Flags: needinfo?(mkelly)
Assignee | ||
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 11•7 years ago
|
||
For the record, the addon in comment 7 was uploaded to Sheild as "Safe Browsing v4 (Gradual Rollout)".
You need to log in
before you can comment on or make changes to this bug.
Description
•