Closed Bug 1393982 Opened 8 years ago Closed 8 years ago

Merge Flash plugin blocklist entries

Categories

(Toolkit :: Blocklist Policy Requests, enhancement, P2)

Product:
Toolkit
Component:
Blocklist Policy Requests
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jorgev, Assigned: jorgev)

References

Details

(Keywords: perf)

This is part of bug 1391792. We have about 80 blocklist entries for the Flash plugin, which can be merged into just 4 different blocks: 1) Windows and Mac, version 26.0.0.131 and older. 2) Linux, version 26.0.0.131 and older. This one needs os="Linux" because otherwise it affects Firefox for Android. 3) Two regular expression blocks for old versions on Linux.
I made all the necessary changes and staged them. This needs to be tested the same way as bug 1380196, since we're just verifying that the latest Flash version is unblocked and older versions are still being blocked.
Flags: needinfo?(andrei.vaida)
Should I be asking someone else for this?
Flags: needinfo?(bogdan.maris)
(In reply to Jorge Villalobos [:jorgev] from comment #2) > Should I be asking someone else for this? We have a lot on our plate right now (this is the reason for the slow reply) but I will give it a spin this week, I'll be back with a comment once I'm done. Leaving the needinfo on me as a reminder.
Flags: needinfo?(bogdan.maris)
We took a look at what Kamil did in https://bugzilla.mozilla.org/show_bug.cgi?id=1380196#c3 but I have to clear something out: - So we should test 26.0.0.131 and older are still blocked and 26.0.0.151 (latest at the moment) is not? I'm asking because there is another version in between 26.0.0.137, which at the moment is not blocked.
Flags: needinfo?(andrei.vaida) → needinfo?(jorge)
> So we should test 26.0.0.131 and older are still blocked and 26.0.0.151 (latest at the moment) is not? That's sufficient, yes.
Flags: needinfo?(jorge)
I tested everything using four older versions and the newest version of Flash. They all are blocked, except the version 26.0.0.137. I tested them on Windows 10 x64, Ubuntu 16.04 x64 and on macOS 10.12 using Latest Nightly 57, Beta 56.0b10 and RC 55.0.3. For full details of our testing please see the following gdoc: https://goo.gl/pWHnRE. My only concern is that in the browser console log I got this result: Blocklist state for Shockwave Flash changed from 4 to 4. Is there a problem there or that is the expected result?
Flags: needinfo?(jorge)
I think that's expected now, since Firefox is making Flash click-to-play by default. Looks good to me.
Flags: needinfo?(jorge)
(In reply to Jorge Villalobos [:jorgev] from comment #7) > I think that's expected now, since Firefox is making Flash click-to-play by > default. Looks good to me. Great! Thanks for clarifying.
Andreas, please push these changes live.
Flags: needinfo?(awagner)
Priority: -- → P2
This is live.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(awagner)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.