1394002 - Suppress gcc warnings in cairo and libpixman

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

These two projects generate a lot of warnings:

>  20 [-Wswitch]
>  16 [-Wincompatible-pointer-types]
>  15 [-Wunused-variable]
>   6 [-Wunused-but-set-variable]
>   4 [-Wnarrowing]
>   3 [-Wsign-compare]
>   1 [-Wint-conversion]

We currently suppress a lot of warnings for them already, so lets round out the set.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1394002 Suppress warnings in third party cairo and libpixman code

Review commit: https://reviewboard.mozilla.org/r/172802/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172802/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8901341 [details]
Bug 1394002 Suppress warnings in third party cairo and libpixman code

https://reviewboard.mozilla.org/r/172802/#review178194

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5868e138b604
Suppress warnings in third party cairo and libpixman code r=jrmuizel

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5868e138b604

Comment 5

[Ionuț Goldan [:igoldan]]

Confirming that some of the compiler warnings have been suppressed:

== Change summary for alert #9021 (as of August 25 2017 22:00 UTC) ==

Improvements:

  2%  compiler warnings summary linux64-noopt debug      406.00 -> 397.92
  1%  compiler warnings summary linux32 debug            537.00 -> 529.00
  1%  compiler warnings summary linux64 debug            547.00 -> 539.00
  1%  compiler warnings summary linux32 opt              569.00 -> 560.83
  1%  compiler warnings summary linux64 opt valgrind     581.00 -> 573.00
  1%  compiler warnings summary linux64 opt              582.00 -> 574.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=9021