1394011 - APZ assert with WebRender turned on

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Assertion failure: result, at /Users/jrmuizel/source/gecko/gfx/layers/apz/src/APZCTreeManager.cpp:2268
#01: mozilla::layers::APZCTreeManager::GetAPZCAtPoint(mozilla::layers::HitTestingTreeNode*, mozilla::gfx::PointTyped<mozilla::ParentLayerPixel, float> const&, mozilla::layers::HitTestResult*, mozilla::layers::HitTestingTreeNode**)[/Users/jrmuizel/source/gecko/obj-x86_64-apple-darwin13.4.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x1d99bc6]

I have some patches applied but I don't think they'd impact this.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

I'll see if I can figure out what's going on here. Do you have any STR?

Comment 2

[Aria Beingessner [:Gankra]]

Think I just hit this:

Assertion failure: result, at /Users/ABeingessner/dev/gecko/gfx/layers/apz/src/APZCTreeManager.cpp:2268
Hit MOZ_CRASH(Aborting on channel error.) at /Users/ABeingessner/dev/gecko/ipc/glue/MessageChannel.cpp:2535
Crash Annotation GraphicsCriticalError: |[C0][GFX1-]: Receive IPC close with reason=AbnormalShutdown (t=1.37746) Hit MOZ_CRASH(MachExceptionHandler: Failed to forward to the previous handler!) at /Users/ABeingessner/dev/gecko/js/src/ds/MemoryProtectionExceptionHandler.cpp:642

repro: fresh debug build of tip, turned on webrender and layers-free (no webrendest) in about:config, *without* disabling APZ. Instantly crashes.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Thanks, I can repro now. Looking into it.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ec2f38c8f27dfb14ffcbf4b7c5d189080daac85

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1394011 - Extract helper function to compute the root ScrollMetadata.

Review commit: https://reviewboard.mozilla.org/r/173760/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173760/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1394011 - Place the root ScrollMetadata on the tree we send to APZ in layers-free webrender mode.

Review commit: https://reviewboard.mozilla.org/r/173762/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173762/

Comment 7

[Markus Stange [:mstange]]

Comment on attachment 8902238 [details]
Bug 1394011 - Extract helper function to compute the root ScrollMetadata.

https://reviewboard.mozilla.org/r/173760/#review179154

Comment 8

[Markus Stange [:mstange]]

Comment on attachment 8902239 [details]
Bug 1394011 - Place the root ScrollMetadata on the tree we send to APZ in layers-free webrender mode.

https://reviewboard.mozilla.org/r/173762/#review179156

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d150d8d67eba
Extract helper function to compute the root ScrollMetadata. r=mstange
https://hg.mozilla.org/integration/autoland/rev/fb438fe5524d
Place the root ScrollMetadata on the tree we send to APZ in layers-free webrender mode. r=mstange

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d150d8d67eba
https://hg.mozilla.org/mozilla-central/rev/fb438fe5524d