Warnings converting from string constant to wchar_t*

RESOLVED FIXED in Firefox 57

Status

()

Product:
Core
Component:
XPCOM
Status:
RESOLVED FIXED
Reported:
a year ago
Modified:
a year ago

People

(Reporter: tjr, Assigned: tjr)

Tracking

(Blocks: 1 bug)

Version:
unspecified
Target:
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [tor])

Attachments

(1 attachment)

Bug 1394013 Fix forbidden string constant assignment
59 bytes, text/x-review-board-request
froydnj
: review+
Details
(Assignee)

Description

•
a year ago 
In several places we use L"" to represent an empty string and pass it to function argument expecting a pointer. This is invalid.
Comment hidden (mozreview-request)

Comment 2

•
a year ago
mozreview-review 
Comment on attachment 8901356 [details]
Bug 1394013 Fix forbidden string constant assignment

https://reviewboard.mozilla.org/r/172816/#review178198
Attachment #8901356 - Flags: review?(nfroyd) → review+
 (Assignee)

Updated

•
a year ago
No longer blocks: 1330608
 (Assignee)

Updated

•
a year ago
Blocks: 1394433
 (Assignee)

Updated

•
a year ago
Keywords: checkin-needed

Comment 4

•
a year ago 
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2b7ede324ce2
Fix forbidden string constant assignment r=froydnj
Keywords: checkin-needed

Comment 5

•
a year ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/2b7ede324ce2
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.