1394013 - Warnings converting from string constant to wchar_t*

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Tom Ritter [:tjr] (OOTO until 7/21)]

In several places we use L"" to represent an empty string and pass it to function argument expecting a pointer. This is invalid.

Comment 1

[Tom Ritter [:tjr] (OOTO until 7/21)]

Attachment: Bug 1394013 Fix forbidden string constant assignment

ISO C++ forbids converting a string constant to 'wchar_t*' [-Werror=write-strings]

Either change it to a nullptr (which has same intent) or pass through a static

Review commit: https://reviewboard.mozilla.org/r/172816/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172816/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8901356 [details]
Bug 1394013 Fix forbidden string constant assignment

https://reviewboard.mozilla.org/r/172816/#review178198

Comment 3

[Tom Ritter [:tjr] (OOTO until 7/21)]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6ba34f75efd0db57a203e8f4ea5bcd850234c2d

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b7ede324ce2
Fix forbidden string constant assignment r=froydnj

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2b7ede324ce2