Closed Bug 1394014 Opened 7 years ago Closed 7 years ago

Disabled users appear in autocompletion when elasticsearch is turned off

Categories

(bugzilla.mozilla.org :: General, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jorgev, Assigned: dylan)

Details

(Keywords: regression)

Attachments

(1 file)

45 bytes, text/x-github-pull-request
dylan
: review+
Details | Review
This user was created a while ago to post abusive comments about add-on signing, in particular referring to me by name: https://bugzilla.mozilla.org/user_profile?login=jorgevillalobosmustdie%40mail.ru

A coworker just pointed out that entering my name in a CC field (and others) will autocomplete and include this user, which isn't a great thing to stumble into. It would be good to anonymize or delete the account.
disabled users are not supposed to show up in autocomplete, so I'll take of that in addition to anonymizing this person. Sorry for the trouble!
Component: Administration → General
Assignee: nobody → dylan
Attached file PR
The code in Bugzilla/User.pm:sub match indicates that the last argument is "exclude disabled". This is a strange default, and probably how this regressed.
Attachment #8901364 - Flags: review?(sebastinssanty)
Comment on attachment 8901364 [details] [review]
PR

r=seban on github.
Attachment #8901364 - Flags: review?(sebastinssanty) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Keywords: regression
Summary: Old abusive username appears in autocomplete → Disabled users appear in autocompletion when elasticsearch is turned off
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: