Make an action task for interactive loaners

RESOLVED FIXED in mozilla57

Status

task
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: bstack, Assigned: bstack)

Tracking

unspecified
mozilla57

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

Assignee

Description

2 years ago
This will be one for docker-worker linux tasks and one for generic-worker windows tasks.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Attachment #8901373 - Flags: review?(dustin)
Attachment #8901970 - Flags: review?(dustin)
Attachment #8901971 - Flags: review?(dustin)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 7

2 years ago
mozreview-review
Comment on attachment 8901373 [details]
Bug 1394026 - Tag tasks with os and worker implementation.

https://reviewboard.mozilla.org/r/172832/#review179024
Attachment #8901373 - Flags: review?(dustin) → review+

Comment 8

2 years ago
mozreview-review
Comment on attachment 8901970 [details]
Bug 1394026 - Enable yaml-based simple actions.

https://reviewboard.mozilla.org/r/173396/#review179026

::: taskcluster/taskgraph/actions/registry.py:334
(Diff revision 1)
>          if f.endswith('.py') and f not in ('__init__.py', 'registry.py', 'util.py'):
>              __import__('taskgraph.actions.' + f[:-3])
> +        if f.endswith('.yml'):
> +            with open(os.path.join(actions_dir, f), 'r') as d:
> +                frontmatter, template = yaml.safe_load_all(d)
> +                register_task_action(**frontmatter)(lambda _: template)

This should probably get a docs update..
Attachment #8901970 - Flags: review?(dustin) → review+

Comment 9

2 years ago
mozreview-review
Comment on attachment 8901971 [details]
Bug 1394026 - Make an interactive loaner action task for linux.

https://reviewboard.mozilla.org/r/173398/#review179030

I nominate you as first author on the O'Reilly "Advanced JSON-e"
Attachment #8901971 - Flags: review?(dustin) → review+
Comment hidden (mozreview-request)

Comment 11

2 years ago
mozreview-review
Comment on attachment 8902345 [details]
Bug 1394026 - Add docs for new action tasks definition format

https://reviewboard.mozilla.org/r/173890/#review179162

::: taskcluster/docs/actions.rst:288
(Diff revision 1)
> +  payload:
> +    command: '...'
> +    env:
> +      TASK_DEFINITION: {'$json': {'eval': 'task'}}
> +
> +These kinds of actions are useful for creating simple derivative tasks, but is

..but are
Attachment #8902345 - Flags: review?(dustin) → review+
Comment hidden (mozreview-request)

Comment 14

2 years ago
Pushed by dmitchell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/58c64dc1a7d1
Tag tasks with os and worker implementation. r=dustin
https://hg.mozilla.org/integration/autoland/rev/eb47ff423f2e
Enable yaml-based simple actions. r=dustin
https://hg.mozilla.org/integration/autoland/rev/0ad4c9bbfc1f
Make an interactive loaner action task for linux. r=dustin
https://hg.mozilla.org/integration/autoland/rev/951cfc00293a
Add docs for new action tasks definition format r=dustin
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Flags: needinfo?(bstack)
Keywords: checkin-needed

Comment 27

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7802d289518a
Tag tasks with os and worker implementation. r=dustin
https://hg.mozilla.org/integration/autoland/rev/e396aeebb120
Enable yaml-based simple actions. r=dustin
https://hg.mozilla.org/integration/autoland/rev/4a096ca3c342
Make an interactive loaner action task for linux. r=dustin
https://hg.mozilla.org/integration/autoland/rev/3ae0fa531315
Add docs for new action tasks definition format r=dustin
Keywords: checkin-needed

Updated

Last year
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.