Closed Bug 1394034 Opened 2 years ago Closed 2 years ago

remove importing jumlib in Thunderbird tests

Categories

(Thunderbird :: Testing Infrastructure, enhancement, trivial)

enhancement
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 57.0

People

(Reporter: aceman, Assigned: aceman)

Details

Attachments

(1 file)

The library resource://mozmill/modules/jum.js is imported in some mozmill tests in Thunderbird. But it seems we do not use any functions from it that are not already available. So remove this dependency.
Comment on attachment 8901379 [details] [diff] [review]
patch

Review of attachment 8901379 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

::: mail/test/mozmill/composition/test-forward-headers.js
@@ +12,5 @@
>  var RELATIVE_ROOT = "../shared-modules";
>  var MODULE_REQUIRES = ["folder-display-helpers", "compose-helpers", "window-helpers",
>                           "message-helpers"];
> +
> +Components.utils.import("resource://gre/modules/Services.jsm");

How did that work without the import?
Attachment #8901379 - Flags: review?(jorgk) → review+
(In reply to Jorg K (GMT+2) from comment #2)
> > +Components.utils.import("resource://gre/modules/Services.jsm");
> 
> How did that work without the import?

It is possible Services are somehow imported globally in some common file started by the test infrastructure.
But I think not everybody liked these hidden imports so we try to explicitly import what each test file needs.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/902ced959704
remove unneeded jumlib from all c-c tests. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 57.0
You need to log in before you can comment on or make changes to this bug.