Closed Bug 1394058 Opened 7 years ago Closed 7 years ago

Safe Browsing options should not be grouped under a "Phishing Protection" heading

Categories

(Firefox :: Settings UI, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- wontfix
firefox57 --- verified

People

(Reporter: francois, Assigned: evanxd, NeedInfo)

Details

(Keywords: regression, Whiteboard: [photon-preference])

Attachments

(2 files)

In the Security section of about:preferences#privacy, the three Safe Browsing options are grouped under a "Phishing Protection" heading.

This is wrong since only half of the first pref is about phishing. The other 2.5 prefs are about malware and unwanted software. The phishing content is also no longer just about phishing, but rather about deceptive content.

An easy fix would be to simply remove the misleading heading.
Summary: Safe Browsing options should not be grouped under "Phishing Protection" → Safe Browsing options should not be grouped under a "Phishing Protection" heading
(In reply to François Marier [:francois] from comment #0)
> In the Security section of about:preferences#privacy, the three Safe
> Browsing options are grouped under a "Phishing Protection" heading.
> 
> This is wrong since only half of the first pref is about phishing. The other
> 2.5 prefs are about malware and unwanted software. The phishing content is
> also no longer just about phishing, but rather about deceptive content.
> 
> An easy fix would be to simply remove the misleading heading.

I don't know if it may break new preference design proposal, we may need to consult UI guys about that.
Evan, I see you landed the new preference changes, do you have any idea about this? Is it ok to remove the heading?
Flags: needinfo?(evan)
Let's get feedback from Tina. She is our UX design for the reorg work.

Hi Tina,

What do you think of Comment 0?
Flags: needinfo?(evan) → needinfo?(thsieh)
Hi Francois,
The "Phishing Protection" copy is a recommendation from the legal team. Unfortunately, we couldn't remove the header since there are 2 sections under Security. I'll suggest finding a proper copy string if it's not the best one. Let's see how legal team think about it :)
Flags: needinfo?(thsieh) → needinfo?(udevi)
Mika is on mat leave so let's redirect the question to Michelle. I do remember bringing this up with Michelle, but I'm not aware of the feedback from legal.
Flags: needinfo?(udevi) → needinfo?(mheubusch)
IIRC, we thought it would be accurate to say "Deceptive Content and Dangerous Software Protection" - I can get final sign off from Elvin if necessary. Francois, is this a correct heading?
Flags: needinfo?(mheubusch)
(In reply to mheubusch from comment #6)
> IIRC, we thought it would be accurate to say "Deceptive Content and
> Dangerous Software Protection" - I can get final sign off from Elvin if
> necessary. Francois, is this a correct heading?

That's accurate.

Are you suggesting that as the heading instead of "Phishing Protection"?
(In reply to François Marier [:francois] from comment #7)
> Are you suggesting that as the heading instead of "Phishing Protection"?

I'm asking just because it seems a little long. It's totally fine from a accuracy point of view.
From Michelle:

"I realize it's long but is only a desktop setting so am not worried about length. We def have the room to accommodate and I'd rather err on the side of accuracy than brevity in this case."

So the proposed replacement heading is "Deceptive Content and Dangerous Software Protection"
Hey Michelle and Francois, can we make it shorter?
We have a room for long strings for sure, but I'm worried about having a title longer than options underneath will make the hierarchy to be unclear.

How about "Dangerous Content Protection"?
Flags: needinfo?(mheubusch)
Flags: needinfo?(francois)
(In reply to Tina Hsieh[:Tina_Hsieh] UX from comment #10)
> Hey Michelle and Francois, can we make it shorter?
> We have a room for long strings for sure, but I'm worried about having a
> title longer than options underneath will make the hierarchy to be unclear.
> 
> How about "Dangerous Content Protection"?

We need to also include the word "deceptive" because it's not all dangerous content.
Flags: needinfo?(francois)
It's too late to do string changes for 56. We could still change this for 57. 
Are you OK leaving this as it is for 56 ? Or, can you come up with a way to change this without removing or adding new strings?
Flags: needinfo?(jaws)
We will just have to live with this for 56 but we still have time to change this for 57 if we can settle on the wording here. It looks like Tina would still prefer something shorter. We're waiting on a response from Michelle for comment 10.

@Evan, while we are waiting for Michelle's response, can you please create the patch to change this string to "Deceptive Content and Dangerous Software Protection" ? Thanks!
Flags: needinfo?(jaws) → needinfo?(evan)
(In reply to (Away until Sept 13th) Jared Wein [:jaws] (please needinfo? me) from comment #13) 
> @Evan, while we are waiting for Michelle's response, can you please create
> the patch to change this string to "Deceptive Content and Dangerous Software
> Protection" ? Thanks!

Sure, let's do it, Jared.
Assignee: nobody → evan
Flags: needinfo?(evan)
Attachment #8906926 - Flags: review?(mconley)
Hi Mike,

Could you help review the patch since Jared is on PTO?

This patch is only changing a string according to Comment 9 and Comment 13.

Thank you.
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [photon-preference][triage]
Target Milestone: --- → Firefox 57
Flags: qe-verify+
QA Contact: hani.yacoub
Whiteboard: [photon-preference][triage] → [photon-preference]
Comment on attachment 8906926 [details]
Bug 1394058 - Change the "Phishing Protection" title to "Deceptive Content and Dangerous Software Protection" since some settings grouped under "Phishing Protection" are about malware and unwanted software.

https://reviewboard.mozilla.org/r/178664/#review183826

Thanks!
Attachment #8906926 - Flags: review?(mconley) → review+
Thank you for the review, Mike. Let's land the patch.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3051cf9176df
Change the "Phishing Protection" title to "Deceptive Content and Dangerous Software Protection" since some settings grouped under "Phishing Protection" are about malware and unwanted software. r=mconley
Keywords: checkin-needed
Build ID: 20170913220121
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.