Closed Bug 1394106 Opened 5 years ago Closed 5 years ago

Toolbar and menubar grippies can not be disabled.


(SeaMonkey :: UI Design, defect)

Not set


(seamonkey2.49esr fixed, seamonkey2.54 fixed, seamonkey2.55 fixed, seamonkey2.53 fixed)

Tracking Status
seamonkey2.49esr --- fixed
seamonkey2.54 --- fixed
seamonkey2.55 --- fixed
seamonkey2.53 --- fixed


(Reporter: frg, Assigned: frg)




(1 file, 2 obsolete files)

I am a little twitchy with the mouse and constantly hide a toolbar via grippy when I really only want to click on "Home" or "Back". I have no use for the grippies anyway and would like to have an option to disable them.
Attached patch 1394106-grippyhide.patch (obsolete) — Splinter Review
This seems to kill them for good via pref.

If you have collaped a toolbar and then set the pref the collapsed state will still be shown. When you "uncollape" it the grippy is gone.

The pref could be exposed in the ui later but this would mean it need to be observed here. So to keep it simple I just added a pref. I don't think anyone would change it more than once during profile lifetime.
Attachment #8901455 - Flags: review?(iann_bugzilla)
Duplicate of this bug: 1400217
Attached patch 1394106-grippyhide-V2.patch (obsolete) — Splinter Review
The modern theme did show the toolbargrippy with the first patch because it didn't inherit the grippyhidden attribute from the superclass.
Attachment #8901455 - Attachment is obsolete: true
Attachment #8901455 - Flags: review?(iann_bugzilla)
Attachment #8908975 - Flags: review?(iann_bugzilla)
Because of how easy it is in glitchy old age to accidentally hit a grippy instead of the actual desired target, moving the pointer in the process if clicking, I've been using userChrome.css to hide grippies for something like 15 years.
Shouldn't the default for browser.toolbars.grippyhidden be defined in browser-prefs.js?
getBoolPref now takes an optional default so its not really needed. But would be easy to change the code.
If you want users to discover the new pref in about:config easily, define the default for it.
Otherwise, it's always effort to explain users how to create a new pref...
Comment on attachment 8908975 [details] [diff] [review]

I think it would be good to have a default in browser-prefs.js as suggested.
r=me with that change.
Attachment #8908975 - Flags: review?(iann_bugzilla) → review+
Pushed by
Enable hiding toolbar grippies via pref. r=IanN
Closed: 5 years ago
Resolution: --- → FIXED
[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: user can't disable grippies
Testing completed (on m-c, etc.): c-esr c-r c-b
Risk to taking this patch (and alternatives if risky): simple patch.
String changes made by this patch: --

Default pref added and parameter for getBoolPref adjusted. r+ from IanN carried forward.

Can I have it in all branches? :)
Attachment #8908975 - Attachment is obsolete: true
Attachment #8914341 - Flags: review+
Attachment #8914341 - Flags: approval-comm-release?
Attachment #8914341 - Flags: approval-comm-esr52?
Attachment #8914341 - Flags: approval-comm-beta?
Target Milestone: --- → seamonkey2.55
Comment on attachment 8914341 [details] [diff] [review]

Attachment #8914341 - Flags: approval-comm-release?
Attachment #8914341 - Flags: approval-comm-release+
Attachment #8914341 - Flags: approval-comm-esr52?
Attachment #8914341 - Flags: approval-comm-esr52+
Attachment #8914341 - Flags: approval-comm-beta?
Attachment #8914341 - Flags: approval-comm-beta+
Fixed for 2.49.2
You need to log in before you can comment on or make changes to this bug.