1394106 - Toolbar and menubar grippies can not be disabled.

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Frank-Rainer Grahl (:frg)]

I am a little twitchy with the mouse and constantly hide a toolbar via grippy when I really only want to click on "Home" or "Back". I have no use for the grippies anyway and would like to have an option to disable them.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1394106-grippyhide.patch

This seems to kill them for good via pref.

If you have collaped a toolbar and then set the pref the collapsed state will still be shown. When you "uncollape" it the grippy is gone.

The pref could be exposed in the ui later but this would mean it need to be observed here. So to keep it simple I just added a pref. I don't think anyone would change it more than once during profile lifetime.

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1394106-grippyhide-V2.patch

The modern theme did show the toolbargrippy with the first patch because it didn't inherit the grippyhidden attribute from the superclass.

Comment 4

[Felix Miata]

Because of how easy it is in glitchy old age to accidentally hit a grippy instead of the actual desired target, moving the pointer in the process if clicking, I've been using userChrome.css to hide grippies for something like 15 years.

Comment 5

[rsx11m]

Shouldn't the default for browser.toolbars.grippyhidden be defined in browser-prefs.js?

Comment 6

[Frank-Rainer Grahl (:frg)]

getBoolPref now takes an optional default so its not really needed. But would be easy to change the code.

Comment 7

[rsx11m]

If you want users to discover the new pref in about:config easily, define the default for it.
Otherwise, it's always effort to explain users how to create a new pref...

Comment 8

[Ian Neal]

Comment on attachment 8908975 [details] [diff] [review]
1394106-grippyhide-V2.patch

I think it would be good to have a default in browser-prefs.js as suggested.
r=me with that change.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/763550197515
Enable hiding toolbar grippies via pref. r=IanN

Comment 10

[Frank-Rainer Grahl (:frg)]

Attachment: 1394106-grippyhide-V3.patch

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: user can't disable grippies
Testing completed (on m-c, etc.): c-esr c-r c-b
Risk to taking this patch (and alternatives if risky): simple patch.
String changes made by this patch: --

Default pref added and parameter for getBoolPref adjusted. r+ from IanN carried forward.

Can I have it in all branches? :)

Comment 11

[Ian Neal]

Comment on attachment 8914341 [details] [diff] [review]
1394106-grippyhide-V3.patch

a=me

Comment 12

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-beta/rev/fcaba4fffb48ad24eca16bb5c22b48bbe67d1556
https://hg.mozilla.org/releases/comm-release/rev/5d4cbfdbc82944a96809505b226a25c57be3d8d5
https://hg.mozilla.org/releases/comm-esr52/rev/d02b7361e22cd1e2144fda3c28f36b23060f190f

Comment 13

[Frank-Rainer Grahl (:frg)]

Fixed for 2.49.2