1394158 - getSelectionDetails should return link information if a URL is highlighted inside an input element

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Thom Chiovoloni [:tcsc] (ex-moco)]

This allows the context menu to show e.g. "Send Link to Device". One obvious use case for this is sites like https://send.firefox.com/ which provide a link inside an `<input>` element for easier copying.

Fairly trivial patch incoming.

Comment 1

[Thom Chiovoloni [:tcsc] (ex-moco)]

Attachment: Bug 1394158 - Make BrowserUtils.getSelectionDetails check for URLs inside editable elements

Review commit: https://reviewboard.mozilla.org/r/172964/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172964/

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

Felipe: feel free to point me at a better reviewer if necessary, wasn't sure who to request from.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8901509 [details]
Bug 1394158 - Make BrowserUtils.getSelectionDetails check for URLs inside editable elements

https://reviewboard.mozilla.org/r/172964/#review178748

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5f4464e0054
Make BrowserUtils.getSelectionDetails check for URLs inside editable elements r=Felipe

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d5f4464e0054

Comment 6

[Flore Allemandou [:flore]]

It seems this patch could be the cause of bug 1420560