Closed
Bug 1394176
Opened 7 years ago
Closed 7 years ago
Crash in mozilla::Scheduler::SetPrefs
Categories
(Core :: DOM: Content Processes, defect)
Core
DOM: Content Processes
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | unaffected |
firefox57 | --- | fixed |
People
(Reporter: marcia, Assigned: mccr8)
Details
(Keywords: crash, regression, topcrash)
Crash Data
Attachments
(1 file)
This bug was filed from the Socorro interface and is report bp-4ff379e1-cb51-403b-95d7-2ebcf0170826. ============================================================= Seen in calixte's report - Linux and Mac crash which started using 20170825100126: http://bit.ly/2wIy0Kj Possible regression range based on crash stats: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d1c70c20e7b52f7295411343e4dc5db8ee7c92b9&tochange=2306e153fba9ca55726ffcce889eaca7a479c29f Maybe related to Bug 1350432? ni on :billm for some insight
Flags: needinfo?(wmccloskey)
Reporter | ||
Comment 1•7 years ago
|
||
I see Windows crashes as well, so changing platform to all.
OS: Mac OS X → All
Hardware: Unspecified → All
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Reporter | ||
Comment 4•7 years ago
|
||
This currently ranks as the top browser crash on Nightly, 346 total crashes/72 installs - most of them Linux.
Keywords: topcrash
Assignee | ||
Comment 5•7 years ago
|
||
I suspect that this is an issue with content and child having different versions. I'm assuming that ContentProcess::Init is called before ContentChild::Init, and this code doesn't look very resilient against -schedulerPrefs not being sent.
Assignee: nobody → continuation
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•7 years ago
|
||
I think this patch is an improvement, but a change to the scheduler pref formatting string could still cause a buffer overflow, which is not great. Maybe the char* should get turned into a safer data structure.
Comment hidden (mozreview-request) |
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8902344 [details] Bug 1394176 - Use default values for scheduler prefs if the parent process didn't send any. https://reviewboard.mozilla.org/r/173888/#review179272 Still not sure if this is really a version mismatch, but I guess we can paper over it for now.
Attachment #8902344 -
Flags: review?(wmccloskey) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: leave-open
Comment 10•7 years ago
|
||
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/af5b39d08a73 Use default values for scheduler prefs if the parent process didn't send any. r=billm
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/af5b39d08a73
Flags: needinfo?(wmccloskey)
Assignee | ||
Comment 12•7 years ago
|
||
This last showed up in the 8-25 build, which is before I landed anything, so it is hard to say if what I did mattered, but I'll close this.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
status-firefox55:
--- → unaffected
status-firefox56:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Keywords: leave-open
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•