Closed Bug 1394191 Opened 2 years ago Closed 2 years ago

Remove unneeded nsContentList.h includes from layout

Categories

(Core :: Layout, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Attachment #8901535 - Flags: review?(dholbert)
Comment on attachment 8901535 [details] [diff] [review]
Remove unneeded nsContentList.h includes from layout

Review of attachment 8901535 [details] [diff] [review]:
-----------------------------------------------------------------

r=me (I'll assume you've verified that these are really unneeded)
Attachment #8901535 - Flags: review?(dholbert) → review+
I did the following quick sanity-check to be sure that none of this header's types (all of which are named ns***List) are really unused in the files touched in this patch:
  for x in $TOUCHED_FILES; do grep "ns[a-zA-Z]*List" $x; done
...and then I did a visual skim of the results of that command. They were all nsI***List, nsDisplayList, nsFrameList, and other list-ish classes unrelated to nsContentList.h.
(Note also that this needs rebasing before it can land, due to conflicts from https://hg.mozilla.org/mozilla-central/diff/69e1415e3ca0/layout/svg/nsSVGUseFrame.cpp )
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/05066c02aca8
Remove unneeded nsContentList.h includes from layout; r=dholbert
https://hg.mozilla.org/mozilla-central/rev/05066c02aca8
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
See Also: → 1483394
You need to log in before you can comment on or make changes to this bug.