1394195 - Fix localization issues in debugger.properties (comments, strings order)

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Francesco Lodolo [:flod] (limited availability until Dec 11)]

As expected, this is causing problems for localizers.

On a side note, those accesskeys seems to be poorly set: why using accesskeys not available in the label, when I assume that a single context menu with plenty of available letters?

Comment 1

[Francesco Lodolo [:flod] (limited availability until Dec 11)]

Side note: case matters.
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Attribute/accesskey

If the label is 'Enable breakpoint', and you set the access key to 'e', the accesskey will be on 'br(e)akpoint', not 'Enable'.

Comment 2

[Francesco Lodolo [:flod] (limited availability until Dec 11)]

Attachment: Bug 1394195 - Reorder and fix access keys, remove unnecessary comments in debugger.properties

Review commit: https://reviewboard.mozilla.org/r/172978/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172978/

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8901537 [details]
Bug 1394195 - Reorder and fix access keys, remove unnecessary comments in debugger.properties

https://reviewboard.mozilla.org/r/172978/#review178502

Thanks for the cleanup Francesco!

Looks good to me, we just need to synchronize this on GitHub after landing on m-c.

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8901537 [details]
Bug 1394195 - Reorder and fix access keys, remove unnecessary comments in debugger.properties

https://reviewboard.mozilla.org/r/172978/#review178504

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb440cde60e8
Reorder and fix access keys, remove unnecessary comments in debugger.properties r=jdescottes

Comment 6

[Julian Descottes [:jdescottes]]

PR ongoing on GitHub: https://github.com/devtools-html/debugger.html/pull/3796

Also opened an issue to hopefully improve the reviews around the properties file on GitHub: https://github.com/devtools-html/debugger.html/issues/3795

Comment 7

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cb440cde60e8