Closed Bug 1394195 Opened 2 years ago Closed 2 years ago
Fix localization issues in debugger
.properties (comments, strings order)
59 bytes, text/x-review-board-request
As expected, this is causing problems for localizers. On a side note, those accesskeys seems to be poorly set: why using accesskeys not available in the label, when I assume that a single context menu with plenty of available letters?
Side note: case matters. https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Attribute/accesskey If the label is 'Enable breakpoint', and you set the access key to 'e', the accesskey will be on 'br(e)akpoint', not 'Enable'.
Comment on attachment 8901537 [details] Bug 1394195 - Reorder and fix access keys, remove unnecessary comments in debugger.properties https://reviewboard.mozilla.org/r/172978/#review178502 Thanks for the cleanup Francesco! Looks good to me, we just need to synchronize this on GitHub after landing on m-c.
Comment on attachment 8901537 [details] Bug 1394195 - Reorder and fix access keys, remove unnecessary comments in debugger.properties https://reviewboard.mozilla.org/r/172978/#review178504
Attachment #8901537 - Flags: review?(jdescottes) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/cb440cde60e8 Reorder and fix access keys, remove unnecessary comments in debugger.properties r=jdescottes
PR ongoing on GitHub: https://github.com/devtools-html/debugger.html/pull/3796 Also opened an issue to hopefully improve the reviews around the properties file on GitHub: https://github.com/devtools-html/debugger.html/issues/3795
You need to log in before you can comment on or make changes to this bug.