In-content prefs category icons not correctly centered with narrow window

RESOLVED FIXED in Thunderbird 57.0

Status

Thunderbird
Theme
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 57.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 months ago
With a narrow window when the category text is hidden, the icons aren't correctly centered on hover.
(Assignee)

Comment 1

2 months ago
Created attachment 8901547 [details] [diff] [review]
PrefsSpacing.patch

I tweaked some paddings/margins to make it like the Add-ons manager. I also followed bug 1388796 and made other changes I've overseen.

I also aligned the categories that they are at the same position as the Add-on categories. I added also a 10px padding on narrow window to the content to not touch the grey category area (FX doesn't need it because they don't made the area grey).

Jörg, open Add-on manager and prefs, then make the window as narrow that the category text is hidden. Now you can switch between Add-on manager and prefs and check if you see a position mismatch (small differences are expected as the icon shapes aren't the same). Hover the categories to see they are now correctly centered.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8901547 - Flags: review?(jorgk)

Comment 2

2 months ago
Comment on attachment 8901547 [details] [diff] [review]
PrefsSpacing.patch

Review of attachment 8901547 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and add-on and in-content prefs pages behave the same now.

r+ with the comment below considered.

::: mail/themes/shared/mail/incontentprefs/aboutPreferences.css
@@ +151,4 @@
>    }
>  
>    #preferencesContainer {
> +    padding-inline-start: 10px;

Make that a little bigger, no? 20px or even the original distance of 28px?
Attachment #8901547 - Flags: review?(jorgk) → review+
(Assignee)

Comment 3

2 months ago
(In reply to Jorg K (GMT+2) from comment #2)
> Comment on attachment 8901547 [details] [diff] [review]
> PrefsSpacing.patch
> 
> Review of attachment 8901547 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good and add-on and in-content prefs pages behave the same now.
> 
> r+ with the comment below considered.
> 
> ::: mail/themes/shared/mail/incontentprefs/aboutPreferences.css
> @@ +151,4 @@
> >    }
> >  
> >    #preferencesContainer {
> > +    padding-inline-start: 10px;
> 
> Make that a little bigger, no? 20px or even the original distance of 28px?

10px is the padding on the right the FX prefs have on narrow windows. With giving this at the left, we are even. I could live with 15px on both sides.

We shouldn't get too much white space in narrow windows to show the content without scrollbars as long as possible. Especially the "Advanced" pane is wide with it's tabs on top (and Mac is the widest with it's standard font).

Comment 4

2 months ago
Hmm, 10px looks disproportionally small. Let's try 15px.
(Assignee)

Comment 5

2 months ago
Created attachment 8901549 [details] [diff] [review]
PrefsSpacing.patch

Okay, with 15px padding.
Attachment #8901547 - Attachment is obsolete: true
Attachment #8901549 - Flags: review+
(Assignee)

Updated

2 months ago
Keywords: checkin-needed

Comment 6

2 months ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/19b1cdcc93f3
Fix spacing of in-content prefs with narrow window. r=jorgk
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

2 months ago
Target Milestone: --- → Thunderbird 57.0
You need to log in before you can comment on or make changes to this bug.