Closed Bug 1394235 Opened 7 years ago Closed 7 years ago

If the button icon is rectangular, the height of the button is incorrect.

Categories

(Firefox :: Toolbars and Customization, defect)

57 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- fixed

People

(Reporter: fx4waldi, Assigned: florian)

References

Details

(Keywords: nightly-community, regression, testcase)

Attachments

(4 files)

Attached file ext.xpi
If the button icon is rectangular (eg. width:1px, height: 30px), the height of the button is incorrect. The icon should be sized to 16x16px.
Bug occurs if the button is in the navigation bar or menu bar. If the button is located on the Bookmark bar height it is just a little bigger. In the overflow menu the button size is correct
Attached image bug.png
Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
Ever confirmed: true
about:debugging has the opposite problem, but this also breaks the layout there.
Attachment #8902267 - Flags: review?(kmaglione+bmo)
Assignee: nobody → florian
Status: NEW → ASSIGNED
This is about:debugging after installing the test add-on in attachment 8901581 [details], without the patch.
Attachment #8902267 - Flags: review?(kmaglione+bmo) → review+
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e59ca9dd30d
If a browser action icon is rectangular, the height of the icon needs to be set, r=kmag.
https://hg.mozilla.org/mozilla-central/rev/9e59ca9dd30d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: