Saved Files and 'Problem loading page' tabs have line under tab head
RESOLVED
FIXED
in Thunderbird 57.0
Status
People
(Reporter: Thomas D. (currently busy elsewhere), Assigned: Paenglab)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
|
13.73 KB,
patch
|
Jorg K (GMT+1)
:
review+
|
Details | Diff | Splinter Review |
With new rectangular tab layout, 'Saved Files' and 'Problem loading page' tabs (potentially other types?) have line under tab head which should be removed. On other tabs like Inbox and Addons Manager, no line seen, head area flows into content area.
|
||
Comment 1•8 months ago
|
||
Yes, the "Saved Files" tab has a line at the bottom. Richard?
Flags: needinfo?(richard.marti)
|
(Assignee) | |
Comment 2•8 months ago
|
||
No, the tab has no line at the bottom, the content has one at the top. ;) For Australis it made sense with the different tab- and content colors. I'm looking at it.
Assignee: nobody → richard.marti
|
|
(Assignee) | |
Comment 3•8 months ago
|
||
Created attachment 8901961 [details] [diff] [review] Download.patch Removed the top border and adapted the background color to the in-content color. I also updated the favicon. I saw, in the saved files tab there are CSS errors because of a missing variable in searchBox.css. This variable is defined in messenger.css which isn't loaded in this tab. I'm on a other bug that touches this file and fix it there.
Flags: needinfo?(richard.marti)
Attachment #8901961 -
Flags: review?(jorgk)
|
|
||
Comment 4•8 months ago
|
||
Comment on attachment 8901961 [details] [diff] [review] Download.patch This is fine. The new download arrow is a little skinny, no? Is that what FF uses?
Attachment #8901961 -
Flags: review?(jorgk) → review+
|
|
(Assignee) | |
Comment 5•8 months ago
|
||
It's the one from the FX downloads button. I think it fits good like it is.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/4b8c6d86e8fe Update the Saved Files tab content to Photon design. r=jorgk
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
|
|
||
Updated•8 months ago
|
||
Target Milestone: --- → Thunderbird 57.0
You need to log in
before you can comment on or make changes to this bug.
Description
•