Closed Bug 1394269 Opened 2 years ago Closed 2 years ago

Saved Files and 'Problem loading page' tabs have line under tab head

Categories

(Thunderbird :: Mail Window Front End, defect, trivial)

Product:
Thunderbird
Component:
Mail Window Front End
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 57.0

People

(Reporter: bugzilla2007, Assigned: Paenglab)

References

Details

Attachments

(1 file)

Download.patch
13.73 KB, patch
jorgk
: review+
Details | Diff | Splinter Review 
With new rectangular tab layout, 'Saved Files' and 'Problem loading page' tabs (potentially other types?) have line under tab head which should be removed.
On other tabs like Inbox and Addons Manager, no line seen, head area flows into content area.
Yes, the "Saved Files" tab has a line at the bottom. Richard?
Flags: needinfo?(richard.marti)
No, the tab has no line at the bottom, the content has one at the top. ;) For Australis it made sense with the different tab- and content colors.

I'm looking at it.
Assignee: nobody → richard.marti
Attached patch Download.patch — — Splinter Review 
Removed the top border and adapted the background color to the in-content color. I also updated the favicon.

I saw, in the saved files tab there are CSS errors because of a missing variable in searchBox.css. This variable is defined in messenger.css which isn't loaded in this tab. I'm on a other bug that touches this file and fix it there.
Flags: needinfo?(richard.marti)
Attachment #8901961 - Flags: review?(jorgk)
Comment on attachment 8901961 [details] [diff] [review]
Download.patch

This is fine. The new download arrow is a little skinny, no? Is that what FF uses?
Attachment #8901961 - Flags: review?(jorgk) → review+
It's the one from the FX downloads button. I think it fits good like it is.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4b8c6d86e8fe
Update the Saved Files tab content to Photon design. r=jorgk
Status: NEW → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 57.0
Depends on: 1406994
You need to log in before you can comment on or make changes to this bug.