Closed
Bug 1394290
Opened 7 years ago
Closed 7 years ago
Optimize Proxy::get for ProxyGet*
Categories
(Core :: JavaScript Engine, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: ting, Assigned: ting)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Spin off from bug 1380061, what we should do here: - Optimize ValueToWindowProxyIfWindow for the case when |v == ObjectValue(*proxy)| - Optimize away |RootedValue receiver| because ProxyGet* have the same declaration Neglect removing CheckRecursionLimit because it doesn't worth it.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
In bug 1380061 comment 19 I said the numbers weren't improved on Windows, but it's not the case. For some reasons, the changes in Proxy.cpp didn't get compiled. The patch improves about 10%.
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8901718 [details] Bug 1394290 - Optimize Proxy::get/set by avoiding unnecessary receiver checking. https://reviewboard.mozilla.org/r/173154/#review178626 Looks great, thanks!
Attachment #8901718 -
Flags: review?(jdemooij) → review+
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → janus926
Pushed by tchou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3880b9e6ada6 Optimize Proxy::get/set by avoiding unnecessary receiver checking. r=jandem
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3880b9e6ada6
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•