Closed
Bug 1394308
Opened 7 years ago
Closed 7 years ago
Fix animation try failures for layers-free
Categories
(Core :: Graphics: WebRender, enhancement, P1)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox56 | --- | unaffected |
firefox57 | --- | unaffected |
People
(Reporter: pchang, Assigned: pchang)
References
Details
(Whiteboard: [wr-mvp] gfx-noted)
Attachments
(2 files)
file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/transform/animate-layer-scale-inherit-1.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/transform/animate-layer-scale-inherit-1-ref.html
Assignee | ||
Updated•7 years ago
|
Whiteboard: gfx-noted
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → howareyou322
Assignee | ||
Comment 1•7 years ago
|
||
After considering the inherited scale from ancestors, the failures could be passed in my local. Later I will upload the patch for review.
Updated•7 years ago
|
Blocks: stage-wr-nightly
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Priority: -- → P3
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: gfx-noted → [wr-mvp] gfx-noted
Target Milestone: --- → mozilla57
Updated•7 years ago
|
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8905343 [details] Bug 1394308 - Apply inherited scale for OMTA to support layers-free, https://reviewboard.mozilla.org/r/177130/#review183282 ::: gfx/layers/wr/StackingContextHelper.h:91 (Diff revision 1) > + // Export the inherited scale > + gfx::Size GetInheritedScale() const { > + return gfx::Size(mXScale, mYScale); > + } > + > + // Provide interface to setup the inhertied scale to support s/inhertied/inherited/ ::: layout/painting/nsDisplayList.cpp:7841 (Diff revision 1) > + // Since we pass nullptr transform to stacking contenxt helper for OMTA, > + // therefore, we have to setup correct inherited scale for this > + // stacking context I think it would be clearer if this comment read like so: Since we passed a nullptr transformForSC to the StackingContextHelper, we now set up the correct inherited scale for the stacking context. (Note that you have a typo "contenxt" in your existing comment also) ::: layout/painting/nsDisplayList.cpp:7844 (Diff revision 1) > + aManager->WrBridge()->AddWebRenderParentCommand(anim); > + > + // Since we pass nullptr transform to stacking contenxt helper for OMTA, > + // therefore, we have to setup correct inherited scale for this > + // stacking context > + newTransformMatrix.PostScale(scale.width,scale.height, 1.0f); nit: space after comma
Attachment #8905343 -
Flags: review?(bugmail) → review+
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8905344 [details] Bug 1394308 - Pass perspective transform attribute to compositor for OMTA, https://reviewboard.mozilla.org/r/177132/#review183290 ::: gfx/layers/wr/StackingContextHelper.h:100 (Diff revision 1) > mYScale = aScale.height; > } > > bool IsBackfaceVisible() const { return mTransform.IsBackfaceVisible(); } > > + bool HasPerspectiveTransform() const { return mHasPerspectiveTransform; } nit: Move this up one line so that it's next to the IsBackfaceVisible() and there's a blank line between it and "private:"
Attachment #8905344 -
Flags: review?(bugmail) → review+
Assignee | ||
Comment 6•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8905343 [details] Bug 1394308 - Apply inherited scale for OMTA to support layers-free, https://reviewboard.mozilla.org/r/177130/#review183282 > s/inhertied/inherited/ Fixed > I think it would be clearer if this comment read like so: > > Since we passed a nullptr transformForSC to the StackingContextHelper, we now set up the correct inherited scale for the stacking context. > > (Note that you have a typo "contenxt" in your existing comment also) Fixed > nit: space after comma Fixed
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 9•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8905344 [details] Bug 1394308 - Pass perspective transform attribute to compositor for OMTA, https://reviewboard.mozilla.org/r/177132/#review183290 > nit: Move this up one line so that it's next to the IsBackfaceVisible() and there's a blank line between it and "private:" Fixed
Comment 10•7 years ago
|
||
Pushed by pchang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6f5ae22906a1 Apply inherited scale for OMTA to support layers-free, r=kats https://hg.mozilla.org/integration/autoland/rev/4b3ef99fb8ca Pass perspective transform attribute to compositor for OMTA, r=kats
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6f5ae22906a1 https://hg.mozilla.org/mozilla-central/rev/4b3ef99fb8ca
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•