1394314 - Inverted icons look faded and no longer have a shadow/border that provides contrast with certain lightweight themes

Status: NEW

(Firefox :: Theme, defect, P2)

Description

[Ossie]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170824053622

Steps to reproduce:

I'm using the PurplePOL theme, which used to give interface buttons like home, favorites and the menu button a blue glow around them. After the automatic update tot 55.0.3 these icons are now bland white.


Actual results:

After the 55.0.3 update all interface buttons have their original style from Compact Dark (white, no border or glow).


Expected results:

Interface buttons should have the style as applied by the active FF theme (in my case white buttons with a blue glow).

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]:

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

We should fix this regression in how themes work, but I don't think release management needs to track the bug. If we do land a fix on m-c, we can still take the patch on beta 56.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Dão, can you help find someone to fix this? Thanks!

Comment 4

[Justin Dolske [:Dolske]]

It would be helpful if you had a screenshot to more accurately describe your problem and help indicate exactly what you're seeing.

PurplePOL appears to be a lightweight theme -- https://addons.mozilla.org/en-us/firefox/addon/purplepol/, so style is a generic browser style we apply plus the background images specific to that theme. AFAICT things are displayed as expected with a LWT, so I don't think there's anything to fix here.

Comment 5

[Ossie]

Attachment: Theme icons in FF 54.0.1

Comment 6

[Ossie]

Attachment: Theme icons in FF 55.0.3

Comment 7

[Ossie]

See added screenshots. It's visible that since FF 55 the shadow on UI icons is no longer present, which does not match the theme (and probably loads of other themes too).

Comment 8

[Dão Gottwald [:dao]]

I looked into adding a drop-shadow like this:

.toolbarbutton-1:-moz-lwtheme-darktext {
  filter: drop-shadow(0 0 1px white);
  text-shadow: none;
}

.toolbarbutton-1:-moz-lwtheme-brighttext {
  filter: drop-shadow(1px 1px 0 rgb(0,0,0,.5));
  text-shadow: none;
}

But this is too expensive and regresses lots of talos tests...

https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=023222e374cfe1e0998584c00ab114ca51bebe1c&newProject=try&newRevision=0e270440634f672264e9b1ba73441d9de29bac78&framework=1&showOnlyConfident=1

https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=023222e374cfe1e0998584c00ab114ca51bebe1c&newProject=try&newRevision=c03ff125dcd334bf40a25d89414cc33978a7d8a2&framework=1&showOnlyConfident=1

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for a fix for 56/57. We could still take a patch in nightly.