bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

[Android O] Temporary disable "Add to Home screen" before we upgrade to API Level 25

VERIFIED FIXED in Firefox 56

Status

()

Firefox for Android
Web Apps
VERIFIED FIXED
11 months ago
21 days ago

People

(Reporter: Nevin Chen(Not active on Bugzilla), Assigned: Nevin Chen(Not active on Bugzilla))

Tracking

unspecified
Firefox 57
Points:
---

Firefox Tracking Flags

(firefox56 verified, firefox57 verified)

Details

(Whiteboard: [FNC][SPT57.3][MVP])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

11 months ago
Per our meeting last week, we'll disable this feature before upgrade to SDK 25.
See Bug 1372926 for more details
(Assignee)

Updated

11 months ago
Duplicate of this bug: 1394355
(Assignee)

Updated

11 months ago
Whiteboard: [FNC][SPT57.3][MVP]
Comment hidden (mozreview-request)
(Assignee)

Updated

11 months ago
Assignee: nobody → cnevinchen

Comment 3

11 months ago
mozreview-review
Comment on attachment 8902553 [details]
Bug 1394356 - Temporary remove add to home screen for Android O.

https://reviewboard.mozilla.org/r/174162/#review179412
Attachment #8902553 - Flags: review?(topwu.tw) → review+

Comment 4

11 months ago
Pushed by nechen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/086838a1d7b2
Temporary remove add to home screen for Android O. r=jwu

Comment 5

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/086838a1d7b2
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
(Assignee)

Comment 6

11 months ago
Comment on attachment 8902553 [details]
Bug 1394356 - Temporary remove add to home screen for Android O.

Approval Request Comment
[Feature/Bug causing the regression]: Android O deprecates old api for add to home creen
[User impact if declined]: Users will have crash on Android O
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: It only hides UI from users to interact with it
[String changes made/needed]: no
Attachment #8902553 - Flags: approval-mozilla-beta?

Updated

10 months ago
status-firefox56: --- → affected

Comment 7

10 months ago
Hi Ioana,
Can you help find someone to verify if this was fixed on Android O with latest nightly?
Flags: qe-verify+
Flags: needinfo?(ioana.chiorean)
Comment on attachment 8902553 [details]
Bug 1394356 - Temporary remove add to home screen for Android O.

Running out of time to fix this in beta. Let's uplift this and verify afterwards in hopes of preventing a crash with Android O.
Attachment #8902553 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Sorina, maybe you can verify this on beta once it lands (should be in beta 11)
Flags: needinfo?(sorina.florean)
Comment hidden (obsolete)

Comment 11

10 months ago
backout
Backed out for Android bustage. Which means it's going to miss b11 now :(. Nevin, can you please come up with a Beta patch ASAP? And I'm wondering if we should consider shipping a b12 later this week for it.
https://treeherder.mozilla.org/logviewer.html#?job_id=130089903&repo=mozilla-beta

https://hg.mozilla.org/releases/mozilla-beta/rev/1b63df5a180b
status-firefox56: fixed → affected
Flags: needinfo?(cnevinchen)
(Assignee)

Comment 12

10 months ago
Created attachment 8906897 [details] [diff] [review]
1394356-beta.patch

Here's the patch for Beta.
Can't we just ride the train without uplift? In that way we don't need this patch?
Flags: needinfo?(cnevinchen)

Comment 13

10 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/ca4f93bbc5e1
status-firefox56: affected → fixed

Comment 14

10 months ago
Verified as disabled on both Nightly (57.0a1 2017-09-19) and Beta (56.0b13).
This issue was tested on a Nexus 6P (Android 8.0)
Flags: needinfo?(sorina.florean)
Flags: needinfo?(ioana.chiorean)

Updated

10 months ago
status-firefox56: fixed → verified
status-firefox57: fixed → verified
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.