Closed Bug 1394356 Opened 2 years ago Closed 2 years ago

[Android O] Temporary disable "Add to Home screen" before we upgrade to API Level 25

Categories

(Firefox for Android :: Web Apps, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 57
Tracking Status
firefox56 --- verified
firefox57 --- verified

People

(Reporter: cnevinchen, Assigned: cnevinchen)

References

Details

(Whiteboard: [FNC][SPT57.3][MVP])

Attachments

(2 files)

Per our meeting last week, we'll disable this feature before upgrade to SDK 25.
See Bug 1372926 for more details
Duplicate of this bug: 1394355
Whiteboard: [FNC][SPT57.3][MVP]
Assignee: nobody → cnevinchen
Comment on attachment 8902553 [details]
Bug 1394356 - Temporary remove add to home screen for Android O.

https://reviewboard.mozilla.org/r/174162/#review179412
Attachment #8902553 - Flags: review?(topwu.tw) → review+
Pushed by nechen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/086838a1d7b2
Temporary remove add to home screen for Android O. r=jwu
https://hg.mozilla.org/mozilla-central/rev/086838a1d7b2
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment on attachment 8902553 [details]
Bug 1394356 - Temporary remove add to home screen for Android O.

Approval Request Comment
[Feature/Bug causing the regression]: Android O deprecates old api for add to home creen
[User impact if declined]: Users will have crash on Android O
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: It only hides UI from users to interact with it
[String changes made/needed]: no
Attachment #8902553 - Flags: approval-mozilla-beta?
Hi Ioana,
Can you help find someone to verify if this was fixed on Android O with latest nightly?
Flags: qe-verify+
Flags: needinfo?(ioana.chiorean)
Comment on attachment 8902553 [details]
Bug 1394356 - Temporary remove add to home screen for Android O.

Running out of time to fix this in beta. Let's uplift this and verify afterwards in hopes of preventing a crash with Android O.
Attachment #8902553 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Sorina, maybe you can verify this on beta once it lands (should be in beta 11)
Flags: needinfo?(sorina.florean)
Backed out for Android bustage. Which means it's going to miss b11 now :(. Nevin, can you please come up with a Beta patch ASAP? And I'm wondering if we should consider shipping a b12 later this week for it.
https://treeherder.mozilla.org/logviewer.html#?job_id=130089903&repo=mozilla-beta

https://hg.mozilla.org/releases/mozilla-beta/rev/1b63df5a180b
Flags: needinfo?(cnevinchen)
Here's the patch for Beta.
Can't we just ride the train without uplift? In that way we don't need this patch?
Flags: needinfo?(cnevinchen)
Verified as disabled on both Nightly (57.0a1 2017-09-19) and Beta (56.0b13).
This issue was tested on a Nexus 6P (Android 8.0)
Flags: needinfo?(sorina.florean)
Flags: needinfo?(ioana.chiorean)
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.