1394383 - Hovering the Search Engines from the Search Suggestions menu in about:newtab or about:home does not change the "Search for <keyword> with:" string

Status: RESOLVED WONTFIX

(Firefox :: Search, defect, P3)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: search suggestions inconsistency.gif

[Affected versions]:
- Firefox 57.0a1 Build ID 	20170827100428

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- browser.newtabpage.activity-stream.enabled is set to true in about:config on a clean new profile.

[Steps to reproduce]:
1. Start the browser with the profile from prerequisites and open a New Tab.
2. Write a keyword in the search bar and hover a search engine button.
3. Observe the string above.
 
[Expected results]:
- "Search for <keyword> with:" string is changed to the hovered search engine's name.

[Actual results]:
- "Search for <keyword> with:" string remains unchanged.

[Notes]:
- If you use the address bar or search bar (toolbar) to do the same steps, the "Search for <keyword> with:" string will be changed with the name of the search engine that is hovered.
- Attached a screen recording of the issue:

Comment 1

[Mark Banner (:standard8)]

As it works with the old page, I think I'll push this in activity stream's direction, as it feels like there is something that is not being set up correctly.

Comment 2

[Ed Lee :Mardak]

It's the same behavior on about:home and tiles about:newtab.

Comment 3

[Ed Lee :Mardak]

The string doesn't even allow for the engine:
https://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/search.properties#40

Comment 4

[Mike Kaply [:mkaply]]

Marking P3. We have this behavior in our other search locations (URL bar, search bar). We should be consistent,

Comment 5

[Mark Banner (:standard8)]

The UI here has changed and we no longer do the change on hover in any of the places where we have one-offs.