1394395 - "\include\mozilla/mscom/PassthruProxy.h(103): error C3646: 'mPreservedStream': unknown override specifier" with --disable-accessibility

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Ryan VanderMeulen (PTO, back July 27)]

c:\Users\Ryan\repos\mozilla\objdir-fx-64\dist\include\mozilla/mscom/PassthruProxy.h(103): error C3646: 'mPreservedStream': unknown override specifier
c:\Users\Ryan\repos\mozilla\objdir-fx-64\dist\include\mozilla/mscom/PassthruProxy.h(103): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:/Users/Ryan/repos/mozilla/ipc/mscom/PassthruProxy.cpp(37): error C2065: 'mPreservedStream': undeclared identifier
c:/Users/Ryan/repos/mozilla/ipc/mscom/PassthruProxy.cpp(45): error C2065: 'mPreservedStream': undeclared identifier
c:/Users/Ryan/repos/mozilla/ipc/mscom/PassthruProxy.cpp(45): error C2228: left of '.release' must have class/struct/union
c:/Users/Ryan/repos/mozilla/ipc/mscom/PassthruProxy.cpp(45): note: type is 'unknown-type'
c:/Users/Ryan/repos/mozilla/ipc/mscom/PassthruProxy.cpp(170): error C2065: 'mPreservedStream': undeclared identifier
c:/Users/Ryan/repos/mozilla/ipc/mscom/PassthruProxy.cpp(174): error C2065: 'mPreservedStream': undeclared identifier
c:/Users/Ryan/repos/mozilla/ipc/mscom/PassthruProxy.cpp(174): error C2227: left of '->Stat' must point to class/struct/union/generic type
c:/Users/Ryan/repos/mozilla/ipc/mscom/PassthruProxy.cpp(174): note: type is 'unknown-type'
c:/Users/Ryan/repos/mozilla/ipc/mscom/PassthruProxy.cpp(205): error C2065: 'mPreservedStream': undeclared identifier
c:/Users/Ryan/repos/mozilla/ipc/mscom/PassthruProxy.cpp(228): error C2065: 'mPreservedStream': undeclared identifier
c:/Users/Ryan/repos/mozilla/ipc/mscom/PassthruProxy.cpp(228): error C2227: left of '->Clone' must point to class/struct/union/generic type
c:/Users/Ryan/repos/mozilla/ipc/mscom/PassthruProxy.cpp(228): note: type is 'unknown-type'
c:/Users/Ryan/repos/mozilla/ipc/mscom/PassthruProxy.cpp(246): error C2065: 'mPreservedStream': undeclared identifier
c:/Users/Ryan/repos/mozilla/ipc/mscom/PassthruProxy.cpp(298): error C2065: 'mPreservedStream': undeclared identifier
c:/Users/Ryan/repos/mozilla/ipc/mscom/PassthruProxy.cpp(301): error C2065: 'mPreservedStream': undeclared identifier
c:/Users/Ryan/repos/mozilla/ipc/mscom/Utils.cpp(266): error C2039: 'GetChromeMainThreadId': is not a member of 'mozilla::dom::ContentChild'
c:\Users\Ryan\repos\mozilla\objdir-fx-64\dist\include\mozilla/dom/ContentChild.h(74): note: see declaration of 'mozilla::dom::ContentChild'
c:/Users/Ryan/repos/mozilla/ipc/mscom/Utils.cpp(265): error C2789: 'parentMainTid': an object of const-qualified type must be initialized
c:/Users/Ryan/repos/mozilla/ipc/mscom/Utils.cpp(265): note: see declaration of 'parentMainTid'
mozmake.EXE[5]: *** [c:/Users/Ryan/repos/mozilla/config/rules.mk:1066: Unified_cpp_ipc_mscom0.obj] Error 2
mozmake.EXE[4]: *** [c:/Users/Ryan/repos/mozilla/config/recurse.mk:73: ipc/mscom/target] Error 2

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Patch

Hey Ryan, can you give this patch a try and let me know if it works for you?

Comment 2

[Ryan VanderMeulen (PTO, back July 27)]

Comment on attachment 8901916 [details] [diff] [review]
Patch

It works!

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8901916 [details] [diff] [review]
Patch

Cleanup patch to fix mscom build errors when accessibility is disabled.

Comment 7

[Ryan VanderMeulen (PTO, back July 27)]

Can I lump in the new bustage from bug 1383501 here as well?

ipc/mscom/ProxyStream.cpp(93): error C3481: 'strActCtx': lambda capture variable not found
ipc/mscom/ProxyStream.cpp(112): error C2064: term does not evaluate to a function taking 0 arguments

Comment 9

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Revised patch

Yup, just revised the patch to include that as well.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c0baa92a5e8
Fix mscom build when ACCESSIBILITY is disabled. r=jimm

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1c0baa92a5e8

Comment 12

[Bill Gianopoulos [:WG9s]]

(In reply to Pulsebot from comment #10)
> Pushed by [e-mail]:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/1c0baa92a5e8
> Fix mscom build when ACCESSIBILITY is disabled. r=jimm

Thanks [e-mail] for fixing!