Closed Bug 1394473 Opened 2 years ago Closed 2 years ago

<a target="_blank"> doesn't do anything in RDM

Categories

(DevTools :: Responsive Design Mode, defect, P1)

defect

Tracking

(firefox-esr52 unaffected, firefox55 unaffected, firefox56 fixed, firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

()

Details

(Keywords: regression)

Attachments

(1 file)

STR:

1. Go to data:text/html,<a href="https://mozilla.org" target="_blank">Target _blank</a>
2. Open RDM
3. Click the link

ER:

The link should open in a new tab.

AR:

Nothing happens.

Browser Console has this error:

TypeError: event.dataTransfer is undefined[Learn More]  tunnel.js:244:11
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment on attachment 8902038 [details]
Bug 1394473 - Fix up target=_blank links in RDM.

https://reviewboard.mozilla.org/r/173440/#review179470

Thanks for maintaining RDM!
Attachment #8902038 - Flags: review?(poirot.alex) → review+
Want to request uplift once this lands?
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #4)
> Want to request uplift once this lands?

Yep, will do!
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9058d354635f
Fix up target=_blank links in RDM. r=ochameau
https://hg.mozilla.org/mozilla-central/rev/9058d354635f
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment on attachment 8902038 [details]
Bug 1394473 - Fix up target=_blank links in RDM.

Approval Request Comment
[Feature/Bug causing the regression]: Unclear what caused the regression, but the fix is more sensible anyway.
[User impact if declined]: If declined, target=_blank links won't open in RDM.
[Is this code covered by automated tests?]: Yes, a new test is added here.
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Only affects certain links inside RDM
[String changes made/needed]: None
Attachment #8902038 - Flags: approval-mozilla-beta?
Comment on attachment 8902038 [details]
Bug 1394473 - Fix up target=_blank links in RDM.

Fix for RDM regression, has new tests. Please uplift for beta 8.
Attachment #8902038 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #8)
> [Is this code covered by automated tests?]: Yes, a new test is added here.
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on J. Ryan's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.