Closed
Bug 1394473
Opened 7 years ago
Closed 7 years ago
<a target="_blank"> doesn't do anything in RDM
Categories
(DevTools :: Responsive Design Mode, defect, P1)
DevTools
Responsive Design Mode
Tracking
(firefox-esr52 unaffected, firefox55 unaffected, firefox56 fixed, firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | fixed |
firefox57 | --- | fixed |
People
(Reporter: jryans, Assigned: jryans)
References
()
Details
(Keywords: regression)
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
ochameau
:
review+
lizzard
:
approval-mozilla-beta+
|
Details |
STR: 1. Go to data:text/html,<a href="https://mozilla.org" target="_blank">Target _blank</a> 2. Open RDM 3. Click the link ER: The link should open in a new tab. AR: Nothing happens. Browser Console has this error: TypeError: event.dataTransfer is undefined[Learn More] tunnel.js:244:11
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3daee751a13a60ffa9f5d2bdeb4632f2d34612e
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8902038 [details] Bug 1394473 - Fix up target=_blank links in RDM. https://reviewboard.mozilla.org/r/173440/#review179470 Thanks for maintaining RDM!
Attachment #8902038 -
Flags: review?(poirot.alex) → review+
Comment 4•7 years ago
|
||
Want to request uplift once this lands?
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #4) > Want to request uplift once this lands? Yep, will do!
Pushed by jryans@gmail.com: https://hg.mozilla.org/integration/autoland/rev/9058d354635f Fix up target=_blank links in RDM. r=ochameau
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9058d354635f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Assignee | ||
Comment 8•7 years ago
|
||
Comment on attachment 8902038 [details] Bug 1394473 - Fix up target=_blank links in RDM. Approval Request Comment [Feature/Bug causing the regression]: Unclear what caused the regression, but the fix is more sensible anyway. [User impact if declined]: If declined, target=_blank links won't open in RDM. [Is this code covered by automated tests?]: Yes, a new test is added here. [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Only affects certain links inside RDM [String changes made/needed]: None
Attachment #8902038 -
Flags: approval-mozilla-beta?
Comment 9•7 years ago
|
||
Comment on attachment 8902038 [details] Bug 1394473 - Fix up target=_blank links in RDM. Fix for RDM regression, has new tests. Please uplift for beta 8.
Attachment #8902038 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 10•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/dcb3e24852c4
Flags: in-testsuite+
Comment 11•7 years ago
|
||
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #8) > [Is this code covered by automated tests?]: Yes, a new test is added here. > [Has the fix been verified in Nightly?]: Yes > [Needs manual test from QE? If yes, steps to reproduce]: No Setting qe-verify- based on J. Ryan's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
Updated•7 years ago
|
status-firefox-esr52:
--- → unaffected
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•