Closed Bug 1394479 Opened 4 years ago Closed 4 years ago

Make browser-test.js subscript loader override less dodgy

Categories

(Firefox :: General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

Details

Attachments

(1 file)

The subscript loader override in browser-test.js affects code that it isn't meant to. We should try to override this in a way that only affects XPCOMUtils.
Comment on attachment 8901885 [details]
Bug 1394479: Only override Services.scriptloader for XPCOMUtils.

https://reviewboard.mozilla.org/r/173314/#review178682

r=me, assuming try is green. (and I indeed wasn't proud of this hack...)
Attachment #8901885 - Flags: review?(florian) → review+
https://hg.mozilla.org/mozilla-central/rev/5b981c6ba496
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.