StrictMode warning from GeckoView.preload

RESOLVED FIXED in Firefox 57

Status

()

Firefox for Android
GeckoView
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 57
All
Android
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

GeckoView.preload calls GeckoProfile.initFromArgs, which accesses the disk. We should be passing null as the profile in this case, and only load the profile when necessary.
Created attachment 8901895 [details] [diff] [review]
Use null as profile in GeckoView.preload (v1)

We should use null as the profile in GeckoView.preload. We will call
GeckoProfile.initFromArgs later on in GeckoThread.getProfile, when the
profile is actually needed.
Attachment #8901895 - Flags: review?(snorp)
Attachment #8901895 - Flags: review?(snorp) → review+

Comment 2

2 months ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3fdbe9b9083b
Use null as profile in GeckoView.preload; r=snorp
https://hg.mozilla.org/mozilla-central/rev/3fdbe9b9083b
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.