1394532 - FirefoxProfileMigrator.js has a bad modeline

Status: RESOLVED FIXED

(Firefox :: Migration, defect)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

When I open browser/components/migration/FirefoxProfileMigrator.js in vim, I get:

Error detected while processing modelines:
line    2:
E518: Unknown option: */

I think it's getting confused by the modelines being a multi-line comment rather than their own comment each.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler]]

(In reply to David Keeler [:keeler] (use needinfo?) from comment #0)
> I think it's getting confused by the modelines being a multi-line comment
> rather than their own comment each.

Whoops - that's not it. Looks like it's missing a 'set'?

http://vim.wikia.com/wiki/Modeline_magic

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: bug 1394532 - fix up modeline in FirefoxProfileMigrator.js

Review commit: https://reviewboard.mozilla.org/r/173386/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173386/

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8901946 [details]
bug 1394532 - fix up modeline in FirefoxProfileMigrator.js

https://reviewboard.mozilla.org/r/173386/#review179134

Comment 4

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/765d2befbd23
fix up modeline in FirefoxProfileMigrator.js r=mossop

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/765d2befbd23