1394573 - Remove the footgun of having --objdir relative to the source checkout

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Steve Fink [:sfink] [:s:]]

Till was unfortunate enough to come across the enormous footgun I had in autospider.py, where it would delete your checkout if you did

    --objdir .

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Remove the footgun of having --objdir relative to the source checkout

The issue is that it was expecting a simple name (eg "obj-spider" or whatever), not a path, and gluing it onto the source checkout path. Which is totally unexpected for the user, and totally unnecessary.

This patch also adds in a sentinel file and will only delete directories marked with that file, for added safety. (I would have made it a dot file, but I'm not sure if it would work on the Windows filesystem.)

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8901986 [details] [diff] [review]
Remove the footgun of having --objdir relative to the source checkout

Review of attachment 8901986 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

::: js/src/devtools/automation/autospider.py
@@ +129,4 @@
>      if clobber:
> +        marker = os.path.join(name, creation_marker_filename)
> +        if os.path.exists(name) and not os.path.exists(marker):
> +            raise Exception("Refusing to delete %s because creation marker %s is missing" % (name, marker))

Perhaps change this to "Refusing to delete targeted objdir %s because it wasn't created by autospider"? Using the marker to ensure this seems like an implementation detail.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d8da479bdd0
Remove the footgun of having --objdir relative to the source checkout, r=till

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d34ea6f47ad
Backed out changeset 4d8da479bdd0 on a CLOSED TREE

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d06fa0b2908
Remove the footgun of having --objdir relative to the source checkout, r=till

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4d06fa0b2908