1394576 - symlinks to files that no longer exist are sticking around in dist/

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The last two times I've updated my tree and rebuilt (sometime last week, and this week), I've noticed that there were symlinks/ in dist that point to files that no longer exist.  I *think* this is a regression.

I notice this because I rsync the result of dist/bin across machines, and rsync considers a symlink that can't be dereferenced to be an I/O error (and thus skips the deletion stage).

A "find <dir> -xtype l" to find all the symlinks pointing to things that don't exist, in dist/, currently found:

firefox-debug/dist/idl/mozIStorageStatementParams.idl
firefox-debug/dist/bin/browser/chrome/browser/skin/classic/browser/[e-mail]
firefox-debug/dist/bin/browser/chrome/browser/skin/classic/browser/reload-stop-go.png
firefox-debug/dist/bin/browser/chrome/en-US/locale/en-US/devtools/client/key-shortcuts.properties
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/common/ShortURL.jsm
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/data/content/assets/glyph-bookmark-remove-16.svg
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/data/content/assets/glyph-now-16.svg
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/data/content/assets/glyph-more-16.svg
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/data/content/assets/glyph-bookmark-16.svg
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/data/content/assets/glyph-newWindow-private-16.svg
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/data/content/assets/glyph-forward-16.svg
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/data/content/assets/glyph-forward-16-white.svg
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/img/icons_default-notification.svg
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/img/icons_sync-notification.svg
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/img/icons_performance-notification.svg
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/img/icons_library-notification.svg
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/img/icons_singlesearch-notification.svg
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/img/icons_customize-notification.svg
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/img/icons_private-notification.svg
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/img/icons_addons-notification.svg
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/skin/osx/editAddress.css
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/skin/linux/editAddress.css
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/skin/windows/editAddress.css
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/manageAddresses.js
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/manageAddresses.css
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/editAddress.js
firefox-debug/dist/include/nsXPIDLString.h

gps thinks this may be related to bug 1390916

(My tree is currently on https://hg.mozilla.org/mozilla-central/rev/3529b653ede2

Comment 1

[Michael Shal [:mshal]]

(In reply to David Baron :dbaron: ⌚️UTC-7 from comment #0)
> gps thinks this may be related to bug 1390916

Yep, this is definitely related - sorry for the issue. Patch forthcoming...

Comment 2

[Michael Shal [:mshal]]

Attachment: Bug 1394576 - Fix install manifests tracking with broken symlinks;

The install manifest with the .track files uses os.path.exists() to
determine if a previously tracked file is no longer installed and needs
to be removed from the system. However, exists() returns False for
broken symlinks, so as far as the manifest is concerned, there is no
file in the filesystem that needs to be removed. We should use lexists()
so we know that the broken symlink still exists in the system so
that it can be removed when the install manifest is processed.

Review commit: https://reviewboard.mozilla.org/r/173490/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173490/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8902078 [details]
Bug 1394576 - Fix install manifests tracking with broken symlinks;

https://reviewboard.mozilla.org/r/173490/#review179130

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a180aac0c7a4
Fix install manifests tracking with broken symlinks; r=gps

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a180aac0c7a4

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I just got another set:
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/data/content/tippytop/images/[e-mail]
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/data/content/tippytop/images/[e-mail]
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/data/content/tippytop/images/[e-mail]
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/data/content/tippytop/images/[e-mail]
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/data/content/tippytop/images/[e-mail]
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/data/content/tippytop/images/[e-mail]
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/data/content/tippytop/images/[e-mail]
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/data/content/tippytop/images/[e-mail]
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/data/content/tippytop/images/[e-mail]
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/data/content/tippytop/images/[e-mail]
firefox-debug/dist/bin/browser/features/[e-mail]/chrome/content/data/content/tippytop/images/[e-mail]
firefox-debug/dist/xpi-stage/mochijar/chrome/mochikit/content/jetpack-package-harness.js
firefox-debug/dist/xpi-stage/mochijar/chrome/mochikit/content/jetpack-addon-overlay.xul
firefox-debug/dist/xpi-stage/mochijar/chrome/mochikit/content/jetpack-package-overlay.xul
firefox-debug/dist/xpi-stage/mochijar/chrome/mochikit/content/jetpack-addon-harness.js
of symlinks that were all created when I built on Monday (September 11), and are now dangling today.

Are you sure this is fixed?

Comment 7

[Michael Shal [:mshal]]

(In reply to David Baron :dbaron: ⌚️UTC-7 from comment #6)
> I just got another set:
> firefox-debug/dist/bin/browser/features/[e-mail]/chrome/
> content/data/content/tippytop/images/[e-mail]
> firefox-debug/dist/bin/browser/features/[e-mail]/chrome/
> content/data/content/tippytop/images/[e-mail]
> firefox-debug/dist/bin/browser/features/[e-mail]/chrome/
> content/data/content/tippytop/images/[e-mail]
> firefox-debug/dist/bin/browser/features/[e-mail]/chrome/
> content/data/content/tippytop/images/[e-mail]
> firefox-debug/dist/bin/browser/features/[e-mail]/chrome/
> content/data/content/tippytop/images/[e-mail]
> firefox-debug/dist/bin/browser/features/[e-mail]/chrome/
> content/data/content/tippytop/images/[e-mail]
> firefox-debug/dist/bin/browser/features/[e-mail]/chrome/
> content/data/content/tippytop/images/[e-mail]
> firefox-debug/dist/bin/browser/features/[e-mail]/chrome/
> content/data/content/tippytop/images/[e-mail]
> firefox-debug/dist/bin/browser/features/[e-mail]/chrome/
> content/data/content/tippytop/images/[e-mail]
> firefox-debug/dist/bin/browser/features/[e-mail]/chrome/
> content/data/content/tippytop/images/[e-mail]
> firefox-debug/dist/bin/browser/features/[e-mail]/chrome/
> content/data/content/tippytop/images/[e-mail]
> firefox-debug/dist/xpi-stage/mochijar/chrome/mochikit/content/jetpack-
> package-harness.js
> firefox-debug/dist/xpi-stage/mochijar/chrome/mochikit/content/jetpack-addon-
> overlay.xul
> firefox-debug/dist/xpi-stage/mochijar/chrome/mochikit/content/jetpack-
> package-overlay.xul
> firefox-debug/dist/xpi-stage/mochijar/chrome/mochikit/content/jetpack-addon-
> harness.js
> of symlinks that were all created when I built on Monday (September 11), and
> are now dangling today.
> 
> Are you sure this is fixed?

The part I fixed was for files that are created by install manifests (so things like XPIDL_SOURCES and EXPORTS now work again, since they used to work but were broken by bug 1390916).

These files are installed by jar manifests, which don't use install manifests in the recursive make backend, so those were always broken. From https://bugzilla.mozilla.org/show_bug.cgi?id=1297381#c1 it sounds like glandium has some patches - do you still have those around? Can we separate out the part related to jar manifest tracking or is it tied to l10n? If not I can try to take a look.

Comment 8

[Mike Hommey [:glandium]]

I do have patches to make the recursive backend essentially do the same thing as the faster make backend, but as you suspect, that's blocked on l10n. It may or may not be worth still going forward when --with-l10n-base is not set, but with the recent l10n changes that don't require it, that's harder...