Closed
Bug 1394580
Opened 7 years ago
Closed 7 years ago
GeckoView startup optimizations
Categories
(GeckoView :: General, enhancement)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(6 files)
59 bytes,
text/x-review-board-request
|
esawin
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
snorp
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
droeh
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
snorp
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
esawin
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
Details |
Small optimizations for GeckoView startup
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8903353 [details] Bug 1394580 - 1. Only load AsyncPrefs for Fennec; https://reviewboard.mozilla.org/r/175150/#review180386
Attachment #8903353 -
Flags: review?(esawin) → review+
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8903357 [details] Bug 1394580 - 5. Lazy-load Task.jsm in Messaging.jsm; https://reviewboard.mozilla.org/r/175158/#review180394
Attachment #8903357 -
Flags: review?(esawin) → review+
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8903354 [details] Bug 1394580 - 2. Add GeckoViewStartup to consolidate startup tasks; https://reviewboard.mozilla.org/r/175152/#review180488 ::: mobile/android/components/geckoview/GeckoViewStartup.js:71 (Diff revision 1) > + (ppmm || mm).forEach(msg => target.addMessageListener(msg, listener)); > + } > + }, > + > + addLazyEventListener: function(aOptions) { > + let {name, target, events, options} = aOptions; You can just do: addLazyEventListener({ name, target, events, options}) { }
Attachment #8903354 -
Flags: review?(snorp) → review+
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8903356 [details] Bug 1394580 - 4. Disable MDNS service for GeckoView; https://reviewboard.mozilla.org/r/175156/#review180490 I think we want to support casting and presentation API, so I think we need to keep this. We're not using the JS implementation, right? How much time does it need on startup?
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8903355 [details] Bug 1394580 - 3. Lazy-load AndroidLog.jsm; https://reviewboard.mozilla.org/r/175154/#review180508 LGTM
Attachment #8903355 -
Flags: review?(droeh) → review+
Assignee | ||
Comment 11•7 years ago
|
||
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #9) > Comment on attachment 8903356 [details] > Bug 1394580 - 4. Disable MDNS service for GeckoView; > > https://reviewboard.mozilla.org/r/175156/#review180490 > > I think we want to support casting and presentation API, so I think we need > to keep this. We're not using the JS implementation, right? How much time > does it need on startup? I guess I see those more as browser features. Seems like the fallback MDNS code is not loaded. Still it does take around 30ms on startup on a Nexus 4.
(In reply to Jim Chen [:jchen] [:darchons] from comment #11) > (In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #9) > > Comment on attachment 8903356 [details] > > Bug 1394580 - 4. Disable MDNS service for GeckoView; > > > > https://reviewboard.mozilla.org/r/175156/#review180490 > > > > I think we want to support casting and presentation API, so I think we need > > to keep this. We're not using the JS implementation, right? How much time > > does it need on startup? > > I guess I see those more as browser features. Seems like the fallback MDNS > code is not loaded. Still it does take around 30ms on startup on a Nexus 4. It's a bit of both, right? A browser probably can't cast a web video without some help from the engine. I guess maybe we can disable it for now and come at it again when we decide we want that.
Comment 13•7 years ago
|
||
mozreview-review |
Comment on attachment 8903356 [details] Bug 1394580 - 4. Disable MDNS service for GeckoView; https://reviewboard.mozilla.org/r/175156/#review180624
Attachment #8903356 -
Flags: review?(snorp) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 20•7 years ago
|
||
mozreview-review |
Comment on attachment 8904683 [details] Bug 1394580 - 6. Use WindowEventDispatcher for prompt if available; https://reviewboard.mozilla.org/r/176484/#review181460
Attachment #8904683 -
Flags: review+
Comment 21•7 years ago
|
||
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b84fc40ed8c2 1. Only load AsyncPrefs for Fennec; r=esawin https://hg.mozilla.org/integration/autoland/rev/6c4c8b4e38cf 2. Add GeckoViewStartup to consolidate startup tasks; r=snorp https://hg.mozilla.org/integration/autoland/rev/995d9ef9af5f 3. Lazy-load AndroidLog.jsm; r=droeh https://hg.mozilla.org/integration/autoland/rev/a9b1cbbeea9a 4. Disable MDNS service for GeckoView; r=snorp https://hg.mozilla.org/integration/autoland/rev/1cc1955d6af3 5. Lazy-load Task.jsm in Messaging.jsm; r=esawin https://hg.mozilla.org/integration/autoland/rev/f069f3c69597 6. Use WindowEventDispatcher for prompt if available; r=jchen
Comment 22•7 years ago
|
||
Backed out for eslint failure at mobile/android/modules/geckoview/Messaging.jsm:201: Missing space after *: https://hg.mozilla.org/integration/autoland/rev/5f721a664bf64fed99184a866b60c24a6afcb3a0 https://hg.mozilla.org/integration/autoland/rev/e2953d11ef63a739d6771a0d710f6e92f5405c1e https://hg.mozilla.org/integration/autoland/rev/90a3ad9bc252daaabb114bf61f8446a90365450a https://hg.mozilla.org/integration/autoland/rev/05ab3965f981e73908af5a0b328f3a2d2429dc39 https://hg.mozilla.org/integration/autoland/rev/96b5a734399c5f5b4ba228cb2b48c4c8f8a6ba18 https://hg.mozilla.org/integration/autoland/rev/52b106ba3e95059cba7da9c22b3165753d40b3ae Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=f069f3c695977904c4b2dda44a5218efe17d28b5&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=128639207&repo=autoland > TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/mobile/android/modules/geckoview/Messaging.jsm:201:26 | Missing space after *. (generator-star-spacing)
Flags: needinfo?(nchen)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 29•7 years ago
|
||
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/71322aab413b 1. Only load AsyncPrefs for Fennec; r=esawin https://hg.mozilla.org/integration/autoland/rev/0fd2ec57de05 2. Add GeckoViewStartup to consolidate startup tasks; r=snorp https://hg.mozilla.org/integration/autoland/rev/aeb4ccaf74b3 3. Lazy-load AndroidLog.jsm; r=droeh https://hg.mozilla.org/integration/autoland/rev/dd645a7a4f81 4. Disable MDNS service for GeckoView; r=snorp https://hg.mozilla.org/integration/autoland/rev/b3b76444d58d 5. Lazy-load Task.jsm in Messaging.jsm; r=esawin https://hg.mozilla.org/integration/autoland/rev/be2d41805031 6. Use WindowEventDispatcher for prompt if available; r=jchen
Comment 30•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/71322aab413b https://hg.mozilla.org/mozilla-central/rev/0fd2ec57de05 https://hg.mozilla.org/mozilla-central/rev/aeb4ccaf74b3 https://hg.mozilla.org/mozilla-central/rev/dd645a7a4f81 https://hg.mozilla.org/mozilla-central/rev/b3b76444d58d https://hg.mozilla.org/mozilla-central/rev/be2d41805031
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(nchen)
Comment 31•7 years ago
|
||
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ef59984ad7b0 7. Follow-up to unpack fields in function signature; r=me
Comment 32•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ef59984ad7b0
Updated•5 years ago
|
Product: Firefox for Android → GeckoView
Updated•5 years ago
|
Target Milestone: Firefox 57 → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•