Closed Bug 139459 Opened 22 years ago Closed 22 years ago

[FIX]Scale continues to shrink

Categories

(Core :: Printing: Output, defect, P1)

Product:
Core
Component:
Printing: Output
Platform:
x86
Windows 2000
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: rods, Assigned: rods)

References

Details

(Whiteboard: [adt2 rtm] [ETA 05/03] custrtm-)

Attachments

(1 file)

patch
1.35 KB, patch
dcone
: review+
attinasi
: superreview+
asa
: approval+
Details | Diff | Splinter Review 
When in print preview, the scale will continue to get smaller becuase it fetches
the mOrigDCScale instead of using the the value from the previous PP data object.
Status: NEW → ASSIGNED
Keywords: nsbeta1
Target Milestone: --- → mozilla1.0
Attached patch patch — — Splinter Review 
Very low risk, when we are already in PP it ned to get the mOrigDCScale value
from the previous PP data object instead of fetching it from the DC, the DC
contains the current value and it may not represent what is actually the
Original value.
Summary: Scale continues to shrink → [FIX]Scale continues to shrink
Comment on attachment 80567 [details] [diff] [review]
patch

r=dcone
Attachment #80567 - Flags: review+
This also fixes bug 135060
Blocks: 135060
Comment on attachment 80567 [details] [diff] [review]
patch

sr=attinasi
Attachment #80567 - Flags: superreview+
Keywords: nsbeta1 → nsbeta1+
Priority: -- → P1
Whiteboard: [adt2]
fixed
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
shrink seems to be working fine...

verified in 4/24 trunk build.
Status: RESOLVED → VERIFIED
Keywords: adt1.0.0
Keywords: approval
Whiteboard: [adt2] → [adt2] [Needs a= & adt1.0.0+]
adt1.0.0+ (on ADT's behalf) approval for checkin to the 1.0 brnach. Pls check
this in after you receive a= from Drivers, then add the fixed1.0.0 keyword.
Keywords: adt1.0.0 → adt1.0.0+
Whiteboard: [adt2] [Needs a= & adt1.0.0+] → [adt2] [Needs a=] [ETA 05/03]
Comment on attachment 80567 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to the 1.0 branch
Attachment #80567 - Flags: approval+
adding adt1.0.0- for beta.  Let's look at this again for rtm.
Keywords: adt1.0.0+ → adt1.0.0-
Whiteboard: [adt2] [Needs a=] [ETA 05/03] → [adt2 rtm] [ETA 05/03]
adding adt1.0.0+.  Please get drivers approval again since it's been 3 days
since the last approval and afterwards checkin to the 1.0 branch.
Keywords: adt1.0.0- → adt1.0.0+
Reapproval granted; get it into the trunk asap.
Keywords: fixed1.0.0
fixed on branch
verified in 5/15 branch.
Keywords: verified1.0.0
Whiteboard: [adt2 rtm] [ETA 05/03] → [adt2 rtm] [ETA 05/03] custrtm-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: