1394648 - Switch from nsInt{Point,Rect,Size} to gfx::Int{Point,Rect,Size} in dom/media/

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We're using nsIntRect, nsIntPoint, and nsIntSize in MediaInfo.h and other media classes. These are actually typedef'd to gfx::IntRect, gfx::IntPoint, and gfx::IntSize in nsRect.h and nsSize.h, which we're including. However a bunch of otherstuff we don't need is also included in those headers, so if we switched to using the gfx classes directly, we'd have a simpler include graph.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Include graph before change

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Include graph after change

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1394648 - Switch from nsInt{Point,Rect,Size} to gfx::Int{Point,Rect,Size} in dom/media.

The nsRect.h and nsSize.h headers typedef nsIntRect to gfx::IntRect etc, so the
rect/size objects we use will be the same, just under a different name.
However the old headers #include a bunch of things we don't use, so we if we
use the gfx objects directly we end up with a smaller include graph.

Review commit: https://reviewboard.mozilla.org/r/173528/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173528/

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d15af8d3f8e50c7979bffbc04b8590ee94aee0c1&selectedJob=126609111

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8902094 [details]
Bug 1394648 - Switch from nsInt{Point,Rect,Size} to gfx::Int{Point,Rect,Size} in dom/media.

https://reviewboard.mozilla.org/r/173528/#review178882

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19c91c598eed
Switch from nsInt{Point,Rect,Size} to gfx::Int{Point,Rect,Size} in dom/media. r=jwwang

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/19c91c598eed