1394649 - Remove TS_ATOM's atoms

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

This atoms are added by bug 199170 to detect inline or block element, but we have same method as HTMLEditor::NodeIsBlockStatic.

Is it still necessary?

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Yeah, I don't think so. We should be able to remove them.

Comment 2

[Makoto Kato [:m_kato]]

HTMLEditor::NodeIsBlockStatic will hit assertion by <noscript> element.  So we might not be able to reuse it

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/worker/workspace/build/tests/reftest/tests/layout/generic/crashtests/1349816-1.html | assertion count 7 is more than expected 0 to 5 assertions

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1394649 - Use nsGkAtoms on nsTextServiceDocument.

It is no reason to use custom atom instead of nsGkAtoms now, so we should
use nsGkAtoms instead.

Review commit: https://reviewboard.mozilla.org/r/191888/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191888/

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8920942 [details]
Bug 1394649 - Use nsGkAtoms on nsTextServiceDocument.

https://reviewboard.mozilla.org/r/191888/#review197088

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 2cc7157cc769 -d 50fbdae0bcd6: rebasing 428852:2cc7157cc769 "Bug 1394649 - Use nsGkAtoms on nsTextServiceDocument. r=masayuki" (tip)
merging editor/txtsvc/nsTextServicesDocument.cpp
merging editor/txtsvc/nsTextServicesDocument.h
warning: conflicts while merging editor/txtsvc/nsTextServicesDocument.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/75caeba85cb5
Use nsGkAtoms on nsTextServiceDocument. r=masayuki

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/75caeba85cb5

Comment 8

[Julien Cristau [:jcristau]]

Doesn't look like a must fix for 57.