Closed
Bug 1394651
Opened 7 years ago
Closed 7 years ago
Remove MediaResource from the base class of HLSResource
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(1 file)
After all the refactoring to MediaResource, HLSResource doesn't need to inherit MediaResource anymore. We can now remove the unimplemented methods that are used at all.
|
Assignee | |
Updated•7 years ago
|
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8902086 -
Flags: review?(gsquelart)
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8902086 [details] Bug 1394651 - remove MediaResource from the base class of HLSResource. https://reviewboard.mozilla.org/r/173512/#review178850
Attachment #8902086 -
Flags: review?(gsquelart) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Thanks for the review!
|
|
Assignee | |
Updated•7 years ago
|
Summary: Remove MediaResource from the base class of HLSResource. → Remove MediaResource from the base class of HLSResource
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/293be271179d remove MediaResource from the base class of HLSResource. r=gerald
|
||
Comment 5•7 years ago
|
||
I don't even think we need HLSResource , could have done without it.
|
|
Assignee | |
Comment 6•7 years ago
|
||
Right, but let's do this step by step for small changes are less risky as far as 57 is concerned.
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/293be271179d
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•