1394651 - Remove MediaResource from the base class of HLSResource

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

After all the refactoring to MediaResource, HLSResource doesn't need to inherit MediaResource anymore. We can now remove the unimplemented methods that are used at all.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1394651 - remove MediaResource from the base class of HLSResource.

Review commit: https://reviewboard.mozilla.org/r/173512/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173512/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8902086 [details]
Bug 1394651 - remove MediaResource from the base class of HLSResource.

https://reviewboard.mozilla.org/r/173512/#review178850

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/293be271179d
remove MediaResource from the base class of HLSResource. r=gerald

Comment 5

[Jean-Yves Avenard [:jya]]

I don't even think we need HLSResource , could have done without it.

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Right, but let's do this step by step for small changes are less risky as far as 57 is concerned.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/293be271179d