Remove MediaResource from the base class of HLSResource

RESOLVED FIXED in Firefox 57

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
After all the refactoring to MediaResource, HLSResource doesn't need to inherit MediaResource anymore. We can now remove the unimplemented methods that are used at all.
(Assignee)

Updated

8 months ago
Assignee: nobody → jwwang
Blocks: 1373160
Priority: -- → P3
Comment hidden (mozreview-request)
(Assignee)

Updated

8 months ago
Attachment #8902086 - Flags: review?(gsquelart)

Comment 2

8 months ago
mozreview-review
Comment on attachment 8902086 [details]
Bug 1394651 - remove MediaResource from the base class of HLSResource.

https://reviewboard.mozilla.org/r/173512/#review178850
Attachment #8902086 - Flags: review?(gsquelart) → review+
(Assignee)

Comment 3

8 months ago
Thanks for the review!
(Assignee)

Updated

8 months ago
Summary: Remove MediaResource from the base class of HLSResource. → Remove MediaResource from the base class of HLSResource

Comment 4

8 months ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/293be271179d
remove MediaResource from the base class of HLSResource. r=gerald
I don't even think we need HLSResource , could have done without it.
(Assignee)

Comment 6

8 months ago
Right, but let's do this step by step for small changes are less risky as far as 57 is concerned.
https://hg.mozilla.org/mozilla-central/rev/293be271179d
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.