Closed Bug 1394654 Opened 7 years ago Closed 7 years ago

remove OS X opengl workaround from Mozilla bug 603134

Categories

(Core :: Widget: Cocoa, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox-esr52 58+ fixed
firefox57 --- fixed

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached patch fix v1.0 (obsolete) — Splinter Review
I think after 7 years it's worth a shot at getting rid of the workaround from bug 603134. OS X has changed a lot since then, as has Firefox.

Recommend taking this patch, keeping an eye out for problems after it lands, we can just put it right back if we see problems.
Attachment #8902087 - Flags: review?(mstange)
Comment on attachment 8902087 [details] [diff] [review]
fix v1.0

Review of attachment 8902087 [details] [diff] [review]:
-----------------------------------------------------------------

I agree, this is definitely worth trying out. Thanks!
Attachment #8902087 - Flags: review?(mstange) → review+
Keywords: checkin-needed
Attachment #8902087 - Attachment is obsolete: true
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/10a488d8110e
Remove OS X opengl workaround from Mozilla bug 603134. r=mstange
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/10a488d8110e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Blocks: 1424945
Josh, do you think it would be possible to backport this patch to ESR 52? It turns out that the workaround from bug 603134 is causing issues on macOS 10.13.2 (see bug 1424945) and ESR 52 is affected by  that.
Flags: needinfo?(jaas)
I would think this patch would be very easy to backport (it's just removing a few isolated lines of code that have been unchanged for a long time) but unfortunately I won't be able to do it any time soon. Sorry.
Flags: needinfo?(jaas)
Looking into it.
Attached patch Patch for ESR 52Splinter Review
[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: There are white flashing artifacts on High Sierra in ESR 52, which affects Tor (see bug 1424945). This patch fixes the issue.
User impact if declined: Tor (and ESR 52 generally) will continue to have disturbing flashing artifacts on macOS 10.13 and above.
Fix Landed on Version: 57
Risk to taking this patch (and alternatives if risky): Minimal. This rode the trains with 57 and we have not seen any regressions.
String or UUID changes made by this patch: none
Attachment #8937426 - Flags: review+
Attachment #8937426 - Flags: approval-mozilla-esr52?
I also recommend uplifting this. Starting with 10.13.2, Firefox builds without this fix sometimes have empty windows, see bug 1429443.
Comment on attachment 8937426 [details] [diff] [review]
Patch for ESR 52

Was fixed in 57, makes sense, ESR52+
Attachment #8937426 - Flags: approval-mozilla-esr52? → approval-mozilla-esr52+
You need to log in before you can comment on or make changes to this bug.