Closed Bug 1394655 Opened 3 years ago Closed 3 years ago

All builds will be busted when Gecko 57 merges to Beta on 2017-09-20

Categories

(Core :: DOM: Content Processes, defect)

defect
Not set
critical

Tracking

()

VERIFIED FIXED
mozilla57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 blocking verified

People

(Reporter: RyanVM, Assigned: mccr8)

References

Details

Attachments

(1 file)

[Tracking Requested - why for this release]: Broken debug builds on the next merge day.

This is blocking my ability to look for other debug test bustage at the moment (including tentative fixes for two known leaks). Please fix ASAP.

https://treeherder.mozilla.org/logviewer.html#?job_id=126609824&repo=try

xpcom/threads/Scheduler.cpp:480:16: error: 'class mozilla::PrioritizedEventQueue<mozilla::AbstractEventQueue>' has no member named 'SetNextIdleDeadlineRef'; did you mean 'GetIdleDeadline'?
xpcom/threads/Scheduler.cpp:480:51: error: 'class nsThread' has no member named 'NextIdleDeadlineRef'
Flags: needinfo?(wmccloskey)
Looks like the debug builds were just the first to fail. All builds are failing now.
Summary: Debug builds are going to permafail when Gecko 57 merges to Beta on 2017-09-20 → All builds will be busted when Gecko 57 merges to Beta on 2017-09-20
As a workaround, you can just delete that line. (The proper fix would be to ifndef it.)
Assignee: nobody → continuation
Flags: needinfo?(wmccloskey)
Comment on attachment 8902099 [details]
Bug 1394655 - Don't call SetNextIdleDeadlineRef on beta or release.

https://reviewboard.mozilla.org/r/173536/#review179042

Maybe we should just stub out the function on beta/release...
Attachment #8902099 - Flags: review?(nfroyd) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/85df0f804dad
Don't call SetNextIdleDeadlineRef on beta or release. r=froydnj
(In reply to Nathan Froyd [:froydnj] from comment #4)
> Maybe we should just stub out the function on beta/release...

I thought about that, but then you'd also have to stub out mainThread->NextIdleDeadlineRef(), and I'm not sure how you should deal with the return value for a stubbed out function. Maybe assert and return some default value?
https://hg.mozilla.org/mozilla-central/rev/85df0f804dad
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.