1394655 - All builds will be busted when Gecko 57 merges to Beta on 2017-09-20

Status: VERIFIED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Broken debug builds on the next merge day.

This is blocking my ability to look for other debug test bustage at the moment (including tentative fixes for two known leaks). Please fix ASAP.

https://treeherder.mozilla.org/logviewer.html#?job_id=126609824&repo=try

xpcom/threads/Scheduler.cpp:480:16: error: 'class mozilla::PrioritizedEventQueue<mozilla::AbstractEventQueue>' has no member named 'SetNextIdleDeadlineRef'; did you mean 'GetIdleDeadline'?
xpcom/threads/Scheduler.cpp:480:51: error: 'class nsThread' has no member named 'NextIdleDeadlineRef'

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Looks like the debug builds were just the first to fail. All builds are failing now.

Comment 2

[Andrew McCreight [:mccr8]]

As a workaround, you can just delete that line. (The proper fix would be to ifndef it.)

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1394655 - Don't call SetNextIdleDeadlineRef on beta or release.

Review commit: https://reviewboard.mozilla.org/r/173536/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173536/

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8902099 [details]
Bug 1394655 - Don't call SetNextIdleDeadlineRef on beta or release.

https://reviewboard.mozilla.org/r/173536/#review179042

Maybe we should just stub out the function on beta/release...

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85df0f804dad
Don't call SetNextIdleDeadlineRef on beta or release. r=froydnj

Comment 6

[Andrew McCreight [:mccr8]]

(In reply to Nathan Froyd [:froydnj] from comment #4)
> Maybe we should just stub out the function on beta/release...

I thought about that, but then you'd also have to stub out mainThread->NextIdleDeadlineRef(), and I'm not sure how you should deal with the return value for a stubbed out function. Maybe assert and return some default value?

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/85df0f804dad