1394656 - Reduce includes in AudioSampleFormat.h and SharedBuffer.h

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

AudioSampleFormat.h includes nsCOMPtr.h, which it does use. This causes cycle collection stuff to be pulled into the build.

It also includes nsAlgorithm.h, which is unsed and pulls in other stuff we don't use.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Chris Pearce (:cpearce) from comment #0)
> AudioSampleFormat.h includes nsCOMPtr.h, which it does use. This causes
> cycle collection stuff to be pulled into the build.

Blah! SharedBuffer.h includes nsCOMPtr, which is unused.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1394656 - Don't include nsAlgorithm.h in AudioSampleFormat.h.

There's nothing in nsAlgorithm.h that we're using in AudioSampleFormat.h,
though it does pull in the definition of NS_ASSERTION(), which we can
replace with an MFBT assertion to simplyfy the include graph.

Review commit: https://reviewboard.mozilla.org/r/173520/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173520/

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1394656 - Don't include nsCOMPtr.h in SharedBuffer.h as its unused.

Including nsCOMPtr also pulls in cycle collection stuff, which complicates the
include graph.

Review commit: https://reviewboard.mozilla.org/r/173522/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173522/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8902089 [details]
Bug 1394656 - Don't include nsAlgorithm.h in AudioSampleFormat.h.

https://reviewboard.mozilla.org/r/173520/#review178878

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8902090 [details]
Bug 1394656 - Don't include nsCOMPtr.h in SharedBuffer.h as its unused.

https://reviewboard.mozilla.org/r/173522/#review178880

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26226638b6a6
Don't include nsAlgorithm.h in AudioSampleFormat.h. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/859bd485c707
Don't include nsCOMPtr.h in SharedBuffer.h as its unused. r=jwwang

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/26226638b6a6
https://hg.mozilla.org/mozilla-central/rev/859bd485c707