Make releaserunner generate nice slugIds

RESOLVED FIXED

Status

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: nthomas, Assigned: jlorenzo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

eg https://public-artifacts.taskcluster.net/-XxUtCX2SR2DA9Y7sOQ49g/0/public/logs/live_backing.log

[taskcluster:error] Task was aborted because states could not be created successfully. Error calling 'link' for taskclusterProxy : Failed to initialize taskcluster proxy service.
[taskcluster 2017-08-29 04:00:18.090Z] Unsuccessful task run with exit code: -1 completed in 90.392 seconds

We haven't seen this with other 56.0b7 tasks, and it was repeatable.
We determined in irc that this is because the taskId starts with `-`.  There's a `slugid.nice()` function which should work to create nicer taskIds that don't start with `-`.
Assignee

Comment 2

2 years ago
I'm on a patch for releasetasks. This may be a fallout of bug 1259627.
Assignee: nobody → jlorenzo
Depends on: 1259627
(In reply to Dustin J. Mitchell [:dustin] from comment #1)
> We determined in irc that this is because the taskId starts with `-`. 
> There's a `slugid.nice()` function which should work to create nicer taskIds
> that don't start with `-`.

We still use 0.0.24, which doesn't support nice slug IDs. Upgrading the library is blocked by https://bugzilla.mozilla.org/show_bug.cgi?id=1257245#c1
OK.  I filed a bug to not fail on such taskIds, although that's probably easier said than done with Golang's command-line processing.
Assignee

Comment 5

2 years ago
Posted file releasetasks PR
There's maybe this workaround. It's not fantastic, but it may temporarily solve the problem while either bug 1257245 or bug 1394894 is resolved.

What do you think, Rail? 

(If it's good enough, I'll make the puppet patch)
Attachment #8902590 - Flags: review?(rail)

Updated

2 years ago
Attachment #8902590 - Flags: review?(rail) → review+
Assignee

Comment 6

2 years ago
I verified the assumption in comment 1, before landing the patch. I created a copy of the task with a different ID[1], and it worked immediately.

Let's make that puppet patch.

[1] https://tools.taskcluster.net/groups/xzIcLIHqSL2rEcHsUf9j9Q/tasks/GiGQzjU2SUGbsBlsX_nYsw/details
Depends on: 1394894
Comment hidden (mozreview-request)

Comment 8

2 years ago
mozreview-review
Comment on attachment 8902657 [details]
Bug 1394664 - Make releaserunner genereate nice slugIds

https://reviewboard.mozilla.org/r/174326/#review179480
Attachment #8902657 - Flags: review?(rail) → review+
Assignee

Updated

2 years ago
Attachment #8902590 - Flags: checked-in+
Assignee

Updated

2 years ago
Summary: Snap generation fails with "Error calling 'link' for taskclusterProxy" → Make releaserunner generate nice slugIds
Assignee

Comment 11

2 years ago
I had forgotten to add the slug package to [1] (I forgot release runner was running python 2). Apart from that, 56.0b7 went out without any failure (related to slugIds).

[1] https://releng-puppet2.srv.releng.scl3.mozilla.com/python/packages/
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.