1394664 - Make releaserunner generate nice slugIds

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, enhancement)

Description

[Nick Thomas [:nthomas] (UTC+12)]

eg https://public-artifacts.taskcluster.net/-XxUtCX2SR2DA9Y7sOQ49g/0/public/logs/live_backing.log

[taskcluster:error] Task was aborted because states could not be created successfully. Error calling 'link' for taskclusterProxy : Failed to initialize taskcluster proxy service.
[taskcluster 2017-08-29 04:00:18.090Z] Unsuccessful task run with exit code: -1 completed in 90.392 seconds

We haven't seen this with other 56.0b7 tasks, and it was repeatable.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

We determined in irc that this is because the taskId starts with `-`.  There's a `slugid.nice()` function which should work to create nicer taskIds that don't start with `-`.

Comment 2

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

I'm on a patch for releasetasks. This may be a fallout of bug 1259627.

Comment 3

[Rail Aliiev [:rail]]

(In reply to Dustin J. Mitchell [:dustin] from comment #1)
> We determined in irc that this is because the taskId starts with `-`. 
> There's a `slugid.nice()` function which should work to create nicer taskIds
> that don't start with `-`.

We still use 0.0.24, which doesn't support nice slug IDs. Upgrading the library is blocked by https://bugzilla.mozilla.org/show_bug.cgi?id=1257245#c1

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

OK.  I filed a bug to not fail on such taskIds, although that's probably easier said than done with Golang's command-line processing.

Comment 5

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

Attachment: releasetasks PR

There's maybe this workaround. It's not fantastic, but it may temporarily solve the problem while either bug 1257245 or bug 1394894 is resolved.

What do you think, Rail? 

(If it's good enough, I'll make the puppet patch)

Comment 6

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

I verified the assumption in comment 1, before landing the patch. I created a copy of the task with a different ID[1], and it worked immediately.

Let's make that puppet patch.

[1] https://tools.taskcluster.net/groups/xzIcLIHqSL2rEcHsUf9j9Q/tasks/GiGQzjU2SUGbsBlsX_nYsw/details

Comment 7

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

Attachment: Bug 1394664 - Make releaserunner genereate nice slugIds

Review commit: https://reviewboard.mozilla.org/r/174326/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174326/

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 8902657 [details]
Bug 1394664 - Make releaserunner genereate nice slugIds

https://reviewboard.mozilla.org/r/174326/#review179480

Comment 9

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

Comment on attachment 8902590 [details] [review]
releasetasks PR

https://github.com/mozilla-releng/releasetasks/commit/a925db2a7f621793ca41836a999a42565e425b01

Comment 10

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

Comment on attachment 8902657 [details]
Bug 1394664 - Make releaserunner genereate nice slugIds

https://hg.mozilla.org/build/puppet/rev/7667ae03ae94cdf0aba205b8fdc96080d0e6dc87

Comment 11

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

I had forgotten to add the slug package to [1] (I forgot release runner was running python 2). Apart from that, 56.0b7 went out without any failure (related to slugIds).

[1] https://releng-puppet2.srv.releng.scl3.mozilla.com/python/packages/