Closed Bug 1394724 Opened 5 years ago Closed 5 years ago

Data race in ChannelMediaResource when HTTP OMT data delivery is enabled

Categories

(Core :: Audio/Video: Playback, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(4 files)

Assignee: nobody → jwwang
Blocks: 1382978
Priority: -- → P1
Attachment #8902548 - Flags: review?(cpearce)
Attachment #8902549 - Flags: review?(cpearce)
Attachment #8902550 - Flags: review?(cpearce)
Attachment #8902551 - Flags: review?(cpearce)
Comment on attachment 8902548 [details]
Bug 1394724. P1 - assert the channel is already closed in ~ChannelMediaResource().

https://reviewboard.mozilla.org/r/174152/#review179720
Attachment #8902548 - Flags: review?(cpearce) → review+
Comment on attachment 8902549 [details]
Bug 1394724. P2 - mListener->Revoke() should happen after mChannel->Cancel() to avoid data race.

https://reviewboard.mozilla.org/r/174154/#review179704

::: commit-message-b2d67:1
(Diff revision 1)
> +Bug 1394724. P2 - mListener->Revoke() should happen after mChannel->Caancel() to avoid data race.

s/Caancel/Cancel/
Attachment #8902549 - Flags: review?(cpearce) → review+
Comment on attachment 8902550 [details]
Bug 1394724. P3 - fix data race in reading mClosed in MediaCacheStream::NotifyDataReceived().

https://reviewboard.mozilla.org/r/174156/#review179722
Attachment #8902550 - Flags: review?(cpearce) → review+
Comment on attachment 8902551 [details]
Bug 1394724. P4 - merge MediaCacheStream::Close() and CloseInternal().

https://reviewboard.mozilla.org/r/174158/#review179726
Attachment #8902551 - Flags: review?(cpearce) → review+
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a81e995c2a6a
P1 - assert the channel is already closed in ~ChannelMediaResource(). r=cpearce
https://hg.mozilla.org/integration/autoland/rev/4e9acbce2e29
P2 - mListener->Revoke() should happen after mChannel->Cancel() to avoid data race. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/a91707ac4a3a
P3 - fix data race in reading mClosed in MediaCacheStream::NotifyDataReceived(). r=cpearce
https://hg.mozilla.org/integration/autoland/rev/87c1afc748cc
P4 - merge MediaCacheStream::Close() and CloseInternal(). r=cpearce
Depends on: 1400155
Blocks: 1428688
No longer blocks: 1428688
You need to log in before you can comment on or make changes to this bug.