Closed
Bug 1394724
Opened 5 years ago
Closed 5 years ago
Data race in ChannelMediaResource when HTTP OMT data delivery is enabled
Categories
(Core :: Audio/Video: Playback, defect, P1)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(4 files)
http://searchfox.org/mozilla-central/rev/cd82cacec2cf734768827ff85ba2dba90a534c5e/dom/media/MediaResource.cpp#154 It is a data race to read mResource off the main thread while Listener::Revoke() [1] is happening on the main thread. [1] http://searchfox.org/mozilla-central/rev/cd82cacec2cf734768827ff85ba2dba90a534c5e/dom/media/MediaResource.h#520
Assignee | ||
Updated•5 years ago
|
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•5 years ago
|
Attachment #8902548 -
Flags: review?(cpearce)
Attachment #8902549 -
Flags: review?(cpearce)
Attachment #8902550 -
Flags: review?(cpearce)
Attachment #8902551 -
Flags: review?(cpearce)
Comment 5•5 years ago
|
||
mozreview-review |
Comment on attachment 8902548 [details] Bug 1394724. P1 - assert the channel is already closed in ~ChannelMediaResource(). https://reviewboard.mozilla.org/r/174152/#review179720
Attachment #8902548 -
Flags: review?(cpearce) → review+
Comment 6•5 years ago
|
||
mozreview-review |
Comment on attachment 8902549 [details] Bug 1394724. P2 - mListener->Revoke() should happen after mChannel->Cancel() to avoid data race. https://reviewboard.mozilla.org/r/174154/#review179704 ::: commit-message-b2d67:1 (Diff revision 1) > +Bug 1394724. P2 - mListener->Revoke() should happen after mChannel->Caancel() to avoid data race. s/Caancel/Cancel/
Attachment #8902549 -
Flags: review?(cpearce) → review+
Comment 7•5 years ago
|
||
mozreview-review |
Comment on attachment 8902550 [details] Bug 1394724. P3 - fix data race in reading mClosed in MediaCacheStream::NotifyDataReceived(). https://reviewboard.mozilla.org/r/174156/#review179722
Attachment #8902550 -
Flags: review?(cpearce) → review+
Comment 8•5 years ago
|
||
mozreview-review |
Comment on attachment 8902551 [details] Bug 1394724. P4 - merge MediaCacheStream::Close() and CloseInternal(). https://reviewboard.mozilla.org/r/174158/#review179726
Attachment #8902551 -
Flags: review?(cpearce) → review+
Assignee | ||
Comment 9•5 years ago
|
||
Thanks for the review!
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 13•5 years ago
|
||
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a81e995c2a6a P1 - assert the channel is already closed in ~ChannelMediaResource(). r=cpearce https://hg.mozilla.org/integration/autoland/rev/4e9acbce2e29 P2 - mListener->Revoke() should happen after mChannel->Cancel() to avoid data race. r=cpearce https://hg.mozilla.org/integration/autoland/rev/a91707ac4a3a P3 - fix data race in reading mClosed in MediaCacheStream::NotifyDataReceived(). r=cpearce https://hg.mozilla.org/integration/autoland/rev/87c1afc748cc P4 - merge MediaCacheStream::Close() and CloseInternal(). r=cpearce
![]() |
||
Comment 14•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a81e995c2a6a https://hg.mozilla.org/mozilla-central/rev/4e9acbce2e29 https://hg.mozilla.org/mozilla-central/rev/a91707ac4a3a https://hg.mozilla.org/mozilla-central/rev/87c1afc748cc
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•