1394731 - The onboarding tour nav item's icon doesn't change to the proper colored icon while mouse hovering

Status: VERIFIED FIXED

(Firefox :: Tours, defect, P2)

Description

[Fischer [:Fischer]]

Attachment: nav_icon_not_change_on_mouse_hovering.gif

See the attached nav_icon_not_change_on_mouse_hovering.gif for this issue.

Root Cause:
Although we specified the nav item's icon should change to the colored version such as [1], but we set `pointer-events: none;` on the nav items so it won't react to the mouse hovering event.

[1] http://searchfox.org/mozilla-central/rev/cd82cacec2cf734768827ff85ba2dba90a534c5e/browser/extensions/onboarding/content/onboarding.css#405
[2] http://searchfox.org/mozilla-central/rev/cd82cacec2cf734768827ff85ba2dba90a534c5e/browser/extensions/onboarding/content/onboarding.css#163

Comment 1

[Fischer [:Fischer]]

Will handle this bug with the bug 1394730 together.

Comment 2

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked for 57, this bug (among others) will track the "Onboarding spec change" work planned for early Beta57

Comment 3

[Fischer [:Fischer]]

Attachment: Bug 1394731 - The onboarding tour nav item's icon doesn't change to the proper colored icon while mouse hovering together,

Fix the regression caused by the bug 1377298

Review commit: https://reviewboard.mozilla.org/r/178254/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/178254/

Comment 4

[Fischer [:Fischer]]

(In reply to Fischer [:Fischer] from comment #1)
> Will handle this bug with the bug 1394730 together.
Per bug 1394730 comment 6, move the patch back to this bug

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8906487 [details]
Bug 1394731 - The onboarding tour nav item's icon doesn't change to the proper colored icon while mouse hovering together,

https://reviewboard.mozilla.org/r/178254/#review183178

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/100136657a8b
The onboarding tour nav item's icon doesn't change to the proper colored icon while mouse hovering together, r=rexboy

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/100136657a8b

Comment 8

[[e-mail]]

do we need uplift this on v56?

Comment 9

[Fischer [:Fischer]]

(In reply to Fred Lin [:gasolin] from comment #8)
> do we need uplift this on v56?
Good question, but 56 release is only 2 days later and this bug isn't too severe to impede usage.

Comment 10

[Md. Majedul islam]

I have reproduced this Bug with nightly 57.0a1 (2017-08-29) on Ubuntu 16.04, 64 Bit!

The bug's fix is now verified on latest nightly 57.0a1

Build ID     20170912100139
User Agent   Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0

Comment 11

[Md. Rahimul Islam]

I have successfully reproduced this bug with Nightly 57.0a1 (2017-08-29) on windows 10 (32-bit)

this bug is verified fix with  latest nightly 57.0a1 (2017-09-12) (32-bit)

Build ID: 20170912100139
Mozilla/5.0 (Windows NT 10.0; rv:57.0) Gecko/20100101 Firefox/57.0

[bugday-20170913]

Comment 12

[Justin [:JW_SoftvisionQA]]

I have verified that this issue has been fixed on today's nightly.

Comment 13

[Cristian Comorasu, QA [:ccomorasu], Release Desktop QA]

I reproduced this issue using Fx 57.0a1, build ID:20170829100404, on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 57.0b7, on Ubuntu 14.04 LTS, macOS X 10.12.6 and Windows 10 x64.