Closed
Bug 1394731
Opened 7 years ago
Closed 7 years ago
The onboarding tour nav item's icon doesn't change to the proper colored icon while mouse hovering
Categories
(Firefox :: Tours, defect, P2)
Firefox
Tours
Tracking
()
VERIFIED
FIXED
Firefox 57
People
(Reporter: Fischer, Assigned: Fischer)
References
Details
(Whiteboard: [photon-onboarding])
Attachments
(2 files)
See the attached nav_icon_not_change_on_mouse_hovering.gif for this issue. Root Cause: Although we specified the nav item's icon should change to the colored version such as [1], but we set `pointer-events: none;` on the nav items so it won't react to the mouse hovering event. [1] http://searchfox.org/mozilla-central/rev/cd82cacec2cf734768827ff85ba2dba90a534c5e/browser/extensions/onboarding/content/onboarding.css#405 [2] http://searchfox.org/mozilla-central/rev/cd82cacec2cf734768827ff85ba2dba90a534c5e/browser/extensions/onboarding/content/onboarding.css#163
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → fliu
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [photon-onboarding]
Assignee | ||
Comment 1•7 years ago
|
||
Will handle this bug with the bug 1394730 together.
Updated•7 years ago
|
Flags: qe-verify+
QA Contact: jwilliams
Tracked for 57, this bug (among others) will track the "Onboarding spec change" work planned for early Beta57
status-firefox57:
--- → affected
tracking-firefox57:
--- → +
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Fischer [:Fischer] from comment #1) > Will handle this bug with the bug 1394730 together. Per bug 1394730 comment 6, move the patch back to this bug
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8906487 [details] Bug 1394731 - The onboarding tour nav item's icon doesn't change to the proper colored icon while mouse hovering together, https://reviewboard.mozilla.org/r/178254/#review183178
Attachment #8906487 -
Flags: review?(rexboy) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/100136657a8b The onboarding tour nav item's icon doesn't change to the proper colored icon while mouse hovering together, r=rexboy
Keywords: checkin-needed
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/100136657a8b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Assignee | ||
Comment 9•7 years ago
|
||
(In reply to Fred Lin [:gasolin] from comment #8) > do we need uplift this on v56? Good question, but 56 release is only 2 days later and this bug isn't too severe to impede usage.
Flags: needinfo?(fliu)
Comment 10•7 years ago
|
||
I have reproduced this Bug with nightly 57.0a1 (2017-08-29) on Ubuntu 16.04, 64 Bit! The bug's fix is now verified on latest nightly 57.0a1 Build ID 20170912100139 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
QA Whiteboard: [bugday-20170913]
Comment 11•7 years ago
|
||
I have successfully reproduced this bug with Nightly 57.0a1 (2017-08-29) on windows 10 (32-bit) this bug is verified fix with latest nightly 57.0a1 (2017-09-12) (32-bit) Build ID: 20170912100139 Mozilla/5.0 (Windows NT 10.0; rv:57.0) Gecko/20100101 Firefox/57.0 [bugday-20170913]
Comment 12•7 years ago
|
||
I have verified that this issue has been fixed on today's nightly.
Status: RESOLVED → VERIFIED
Comment 13•7 years ago
|
||
I reproduced this issue using Fx 57.0a1, build ID:20170829100404, on Windows 10 x64. I can confirm this issue is fixed, I verified using Fx 57.0b7, on Ubuntu 14.04 LTS, macOS X 10.12.6 and Windows 10 x64.
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•