1394740 - Update permissions string for Find API

Status: VERIFIED FIXED

(WebExtensions :: General, defect)

Description

[Francesco Lodolo [:flod]]

(In reply to sdevaney from comment #183)
> Ah. Thanks for the photon style guide reference re: "web" (it has
> historically been capitalized on AMO but let's defer to photon style for
> this). And after reflection I agree the wording "web page text" is awkward
> an arguably unnecessary. Let's just go with...
> 
> Read the text of all open tabs.

Comment 1

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #0)
> Read the text of all open tabs.

Note that I'm going to leave out the final period, since that's the format of all permission strings.

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Bug 1394740 - Update permissions string for Find API

Review commit: https://reviewboard.mozilla.org/r/173624/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173624/

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 8902163 [details]
Bug 1394740 - Update permissions string for Find API

https://reviewboard.mozilla.org/r/173624/#review178946

Per discussion in bug 1332144, I'm adding a technical review on the patch, the wording is already agreed upon.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d5100d775fb
Update permissions string for Find API r=Pike

Comment 5

[sdevaney]

> Note that I'm going to leave out the final period, since that's the format
> of all permission strings.

Yes! Good catch.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9d5100d775fb

Comment 7

[CosminB]

Attachment: 1394740.png

This issue is verified as fixed on Firefox  58.0a1 (20171018100140) and Firefox 57.0b9 (20171016185129) Dev Edition under Wind 7 64-bit and Mac OS X 10.13.

The string from the find API has been changed from “Read the Web page text of all open tabs” to “Read the text of all open tabs”.

Please see the attached screenshot.