Closed Bug 1394740 Opened 3 years ago Closed 3 years ago

Update permissions string for Find API

Categories

(WebExtensions :: General, defect)

defect
Not set
normal

Tracking

(firefox57 verified, firefox58 verified)

VERIFIED FIXED
mozilla57
Tracking Status
firefox57 --- verified
firefox58 --- verified

People

(Reporter: flod, Assigned: flod)

References

Details

Attachments

(2 files)

(In reply to sdevaney from comment #183)
> Ah. Thanks for the photon style guide reference re: "web" (it has
> historically been capitalized on AMO but let's defer to photon style for
> this). And after reflection I agree the wording "web page text" is awkward
> an arguably unnecessary. Let's just go with...
> 
> Read the text of all open tabs.
(In reply to Francesco Lodolo [:flod] from comment #0)
> Read the text of all open tabs.

Note that I'm going to leave out the final period, since that's the format of all permission strings.
Comment on attachment 8902163 [details]
Bug 1394740 - Update permissions string for Find API

https://reviewboard.mozilla.org/r/173624/#review178946

Per discussion in bug 1332144, I'm adding a technical review on the patch, the wording is already agreed upon.
Attachment #8902163 - Flags: review?(l10n) → review+
Pushed by francesco.lodolo@mozillaitalia.org:
https://hg.mozilla.org/integration/autoland/rev/9d5100d775fb
Update permissions string for Find API r=Pike
> Note that I'm going to leave out the final period, since that's the format
> of all permission strings.

Yes! Good catch.
https://hg.mozilla.org/mozilla-central/rev/9d5100d775fb
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Attached image 1394740.png
This issue is verified as fixed on Firefox  58.0a1 (20171018100140) and Firefox 57.0b9 (20171016185129) Dev Edition under Wind 7 64-bit and Mac OS X 10.13.

The string from the find API has been changed from “Read the Web page text of all open tabs” to “Read the text of all open tabs”.

Please see the attached screenshot.
Status: RESOLVED → VERIFIED
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.