Closed
Bug 1394762
Opened 7 years ago
Closed 7 years ago
Figure out an automated test-case for bug 1394311
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox55 | --- | unaffected |
firefox56 | --- | fixed |
firefox57 | --- | fixed |
People
(Reporter: emilio, Assigned: kevin.hsieh)
References
Details
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
manishearth
:
review+
gchang
:
approval-mozilla-beta+
|
Details |
See the discussion in that bug.
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(kevin.hsieh)
Assignee | ||
Comment 1•7 years ago
|
||
I created a reftest that uses the default generic pref as a proxy for checking whether the lang tag was applied, but I'm still in the process of making sure it covers as many cases as possible.
Assignee: nobody → kevin.hsieh
Status: NEW → ASSIGNED
Flags: needinfo?(kevin.hsieh)
Reporter | ||
Comment 2•7 years ago
|
||
Thank you so much, that's great :)
Assignee | ||
Comment 3•7 years ago
|
||
I'm also trying to avoid Bug 1367860 so that we can nominate emilio's patch for beta uplift, since the regression occurred in 56.
status-firefox55:
--- → unaffected
status-firefox56:
--- → affected
status-firefox57:
--- → affected
See Also: → 1367860
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•7 years ago
|
||
Before 1394311 patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa6ead1a3f147801d68beae62919ee3b545e3a86 After 1394311 patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba3b2126fbade400b7df4d89f7ec5b3a655635e8
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8902418 [details] Bug 1394762: Add testcase for Bug 1394311. https://reviewboard.mozilla.org/r/174002/#review179206
Attachment #8902418 -
Flags: review?(manishearth) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/70052a839bc1 Add testcase for Bug 1394311. r=manishearth
Keywords: checkin-needed
Assignee | ||
Comment 8•7 years ago
|
||
Comment on attachment 8902418 [details] Bug 1394762: Add testcase for Bug 1394311. Approval Request Comment [Feature/Bug causing the regression]: Bug 1370802 "There's actually no need for lang to be lowercased." [User impact if declined]: Breakage and/or inconsistent rendering of pages with East Asian text [Is this code covered by automated tests?]: Yes (this is the automated test for Bug 1394311) [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: Bug 1394311 (the actual patch) [Is the change risky?]: No [Why is the change risky/not risky?]: It's a one-line change that fixes a regression. [String changes made/needed]: None
Attachment #8902418 -
Flags: approval-mozilla-beta?
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/70052a839bc1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 10•7 years ago
|
||
Comment on attachment 8902418 [details] Bug 1394762: Add testcase for Bug 1394311. Add tests for bug 1394311. Beta56+.
Attachment #8902418 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 11•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/346027fa6dc3
Flags: in-testsuite+
Comment 12•7 years ago
|
||
(In reply to Kevin Hsieh from comment #8) > [Is this code covered by automated tests?]: Yes (this is the automated test > for Bug 1394311) > [Has the fix been verified in Nightly?]: Yes > [Needs manual test from QE? If yes, steps to reproduce]: No Setting qe-verify- based on Kevin's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•