Closed Bug 1394784 Opened 2 years ago Closed 2 years ago

test_signed_updatepref.js is going to permafail on DevEdition when Gecko 57 merges to Beta on 2017-09-20

Categories

(Toolkit :: Add-ons Manager, defect, critical)

defect
Not set
critical

Tracking

()

VERIFIED FIXED
mozilla57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 + verified

People

(Reporter: RyanVM, Assigned: aswan)

References

Details

Attachments

(1 file)

[Tracking Requested - why for this release]: Permafailing xpcshell test on the next merge day.

Got a bit lost in the other failures of bug 1393156 because it was DevEdition-only.

https://treeherder.mozilla.org/logviewer.html#?job_id=126631527&repo=try

TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_signed_updatepref.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_signed_updatepref.js | - false == true
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_signed_updatepref.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_signed_updatepref.js | - false == true
Flags: needinfo?(aswan)
So dev edition is supposed to allow legacy extensions, bug 1363897 is for the releng work to implement that.
I guess the proper thing is to skip this test if either the signing or legacy extensions pref is allowed to be flipped, though in practice we either allow both to be flipped or neither.
Assignee: nobody → aswan
Flags: needinfo?(aswan)
Attachment #8903106 - Flags: review?(rhelmer)
Comment on attachment 8903106 [details]
Bug 1394784 Skip legacy extension test if legacy extensions are disallowed

https://reviewboard.mozilla.org/r/174898/#review180010
Attachment #8903106 - Flags: review?(rhelmer) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a7db9780ad98
Skip legacy extension test if legacy extensions are disallowed r=rhelmer
https://hg.mozilla.org/mozilla-central/rev/a7db9780ad98
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.